More sensible default size / position for .srt subs.

diff --git a/ChangeLog b/ChangeLog
index 74b2cb0a2b58c75b0307c4c352b14d41d880845c..586d33abd61292f820165df1920b100cd2f5e3cb 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2014-10-05  Carl Hetherington  <cth@carlh.net>
+
+       * Use a more sensible default position and size for
+       .srt subs.
+
 2014-10-01  Carl Hetherington  <cth@carlh.net>
 
        * Version 2.0.13 released.

diff --git a/src/lib/subrip_decoder.cc b/src/lib/subrip_decoder.cc
index e2bdc347b93b202183d483f6a606dfc665324a13..2ae285b5ede17586143aa56728f37e2877a773b3 100644 (file)
--- a/src/lib/subrip_decoder.cc
+++ b/src/lib/subrip_decoder.cc
@@ -52,6 +52,8 @@ SubRipDecoder::pass ()
        if (_next >= _subtitles.size ()) {
                return true;
        }
+
+       /* XXX: we are ignoring positioning specified in the file */
        
        list<dcp::SubtitleString> out;
        for (list<SubRipSubtitlePiece>::const_iterator i = _subtitles[_next].pieces.begin(); i != _subtitles[_next].pieces.end(); ++i) {
@@ -60,10 +62,11 @@ SubRipDecoder::pass ()
                                "Arial",
                                i->italic,
                                dcp::Color (255, 255, 255),
-                               72,
+                               /* .srt files don't specify size, so this is an arbitrary value */
+                               48,
                                dcp::Time (rint (_subtitles[_next].period.from.seconds() * 250)),
                                dcp::Time (rint (_subtitles[_next].period.to.seconds() * 250)),
-                               0.9,
+                               0.2,
                                dcp::BOTTOM,
                                i->text,
                                dcp::NONE,