dcpomatic.git
2 months agoFix failing tests.
Carl Hetherington [Mon, 11 Mar 2024 14:25:16 +0000 (15:25 +0100)]
Fix failing tests.

Broken in the fix for #2780, when we started to check that referenced
audio MXFs have the correct number of channels.

2 months agoUse stored has_non_zero_entry_point() instead of parsing the DCP again (#2524).
Carl Hetherington [Wed, 6 Mar 2024 00:17:59 +0000 (01:17 +0100)]
Use stored has_non_zero_entry_point() instead of parsing the DCP again (#2524).

2 months agoTake has_non_zero_entry_point() from examiner and store it.
Carl Hetherington [Wed, 6 Mar 2024 00:17:27 +0000 (01:17 +0100)]
Take has_non_zero_entry_point() from examiner and store it.

2 months agoOffer has_non_zero_entry_point() from DCPExaminer.
Carl Hetherington [Wed, 6 Mar 2024 00:17:05 +0000 (01:17 +0100)]
Offer has_non_zero_entry_point() from DCPExaminer.

2 months agoRemove redundant DCPDecoder use.
Carl Hetherington [Wed, 6 Mar 2024 00:17:40 +0000 (01:17 +0100)]
Remove redundant DCPDecoder use.

2 months agoAdd a temporary to reduce some boilerplate.
Carl Hetherington [Wed, 6 Mar 2024 00:15:46 +0000 (01:15 +0100)]
Add a temporary to reduce some boilerplate.

2 months agoUse openjpeg v2.5.2 (#2783).
Carl Hetherington [Fri, 8 Mar 2024 21:31:01 +0000 (22:31 +0100)]
Use openjpeg v2.5.2 (#2783).

Tests suggest it is considerably faster:

* arrietty on Linux/AMD
  old: 03:35
  new: 03:58

* Sintel.2010.1080p.mkv on Linux/AMD
  old: 0:29:49
  new: 0:22:39

* TRAILER VERSIE 4.mov on Apple M1
  old: 6:22
  new: 5:15

* TRAILER VERSIE 4.mov on Windows/Intel
  old: 6:10
  new: 4:12

2 months agoMake check_one_frame more verbose when it fails.
Carl Hetherington [Fri, 8 Mar 2024 21:30:28 +0000 (22:30 +0100)]
Make check_one_frame more verbose when it fails.

2 months agoFix memory leak in test.
Carl Hetherington [Sat, 2 Mar 2024 22:19:25 +0000 (23:19 +0100)]
Fix memory leak in test.

2 months agoMerge branch 'main' into v2.17.x
Carl Hetherington [Fri, 8 Mar 2024 23:11:38 +0000 (00:11 +0100)]
Merge branch 'main' into v2.17.x

2 months agoAdd <PlayerRestrictedMenus> option to config.xml (#2725).
Carl Hetherington [Fri, 8 Mar 2024 22:24:31 +0000 (23:24 +0100)]
Add <PlayerRestrictedMenus> option to config.xml (#2725).

This hides all player menus except "File".

2 months agoFix screen name order in KDM emails.
Carl Hetherington [Thu, 7 Mar 2024 22:33:03 +0000 (23:33 +0100)]
Fix screen name order in KDM emails.

2 months agoUse dcp_name (probably ISDCF name) for CPL_NAME in KDM emails (#2787).
Carl Hetherington [Thu, 7 Mar 2024 20:03:31 +0000 (21:03 +0100)]
Use dcp_name (probably ISDCF name) for CPL_NAME in KDM emails (#2787).

2 months agoStore attachment contents in the Email object.
Carl Hetherington [Thu, 7 Mar 2024 15:40:03 +0000 (16:40 +0100)]
Store attachment contents in the Email object.

2 months agoRename Emailer -> Email.
Carl Hetherington [Thu, 7 Mar 2024 15:12:22 +0000 (16:12 +0100)]
Rename Emailer -> Email.

2 months agoAdd a couple more Dolby certificate location / filename pairs.
Carl Hetherington [Mon, 4 Mar 2024 21:34:52 +0000 (22:34 +0100)]
Add a couple more Dolby certificate location / filename pairs.

2 months agoBuild for Ubuntu 24.04.
Carl Hetherington [Fri, 1 Mar 2024 12:42:50 +0000 (13:42 +0100)]
Build for Ubuntu 24.04.

2 months agoAdd Shift+scrollwheel to move left/right in the timeline.
Carl Hetherington [Tue, 27 Feb 2024 00:11:52 +0000 (01:11 +0100)]
Add Shift+scrollwheel to move left/right in the timeline.

2 months agoAdd Ctrl+scrollwheel zoom to the timeline (#2781).
Carl Hetherington [Mon, 26 Feb 2024 23:57:51 +0000 (00:57 +0100)]
Add Ctrl+scrollwheel zoom to the timeline (#2781).

2 months agoDisallow referring to OV audio unless channel counts match (#2780).
Carl Hetherington [Mon, 26 Feb 2024 22:18:15 +0000 (23:18 +0100)]
Disallow referring to OV audio unless channel counts match (#2780).

2 months agoMerge tag 'v2.16.78' into v2.17.x v2.17.12
Carl Hetherington [Thu, 22 Feb 2024 00:25:03 +0000 (01:25 +0100)]
Merge tag 'v2.16.78' into v2.17.x

2 months agoMake DCPExaminer::size() optional and deal with the consequences. v2.16.78
Carl Hetherington [Wed, 21 Feb 2024 09:47:38 +0000 (10:47 +0100)]
Make DCPExaminer::size() optional and deal with the consequences.

This means we can fix the case of a VF having no known size in a nice way,
in turn fixing problems caused by the fix to #2775.

2 months agoFix failure to examine non-flat-ratio VFs (#2775).
Carl Hetherington [Wed, 21 Feb 2024 00:10:23 +0000 (01:10 +0100)]
Fix failure to examine non-flat-ratio VFs (#2775).

2 months agoSame trick again with gcc 8.3.0 (Debian 10).
Carl Hetherington [Tue, 20 Feb 2024 23:41:17 +0000 (00:41 +0100)]
Same trick again with gcc 8.3.0 (Debian 10).

2 months agoDon't use -Wsuggest-override on gcc 7.5.0 (Ubuntu 18.04)
Carl Hetherington [Tue, 20 Feb 2024 21:57:01 +0000 (22:57 +0100)]
Don't use -Wsuggest-override on gcc 7.5.0 (Ubuntu 18.04)

because turning it off with a pragma seems not to work.

2 months agoFix build on Centos 7.
Carl Hetherington [Tue, 20 Feb 2024 13:37:58 +0000 (14:37 +0100)]
Fix build on Centos 7.

2 months agoMerge tag 'v2.16.77' into v2.17.x
Carl Hetherington [Mon, 19 Feb 2024 22:22:31 +0000 (23:22 +0100)]
Merge tag 'v2.16.77' into v2.17.x

2 months agoSupporters update. v2.16.77
Carl Hetherington [Mon, 19 Feb 2024 21:29:53 +0000 (22:29 +0100)]
Supporters update.

2 months agoDon't order the user to 'remove the other content'.
Carl Hetherington [Mon, 19 Feb 2024 20:42:39 +0000 (21:42 +0100)]
Don't order the user to 'remove the other content'.

In the context of the new VF dialog this sounds odd; e.g. the user ticked video
but audio is impossible, they are ordered to remove the other content (when they
might just not want to refer to audio at all).

2 months agoSupporters update.
Carl Hetherington [Mon, 19 Feb 2024 13:45:38 +0000 (14:45 +0100)]
Supporters update.

2 months agoFix various preview errors on high-DPI screens (#2774).
Carl Hetherington [Mon, 19 Feb 2024 13:41:49 +0000 (14:41 +0100)]
Fix various preview errors on high-DPI screens (#2774).

The logical scale was previously not taken into account so the outline
rectangle was wrong and the padding was usually missing.

2 months agoCleanup: use a dcp::Size instead of a wxSize.
Carl Hetherington [Mon, 19 Feb 2024 13:40:02 +0000 (14:40 +0100)]
Cleanup: use a dcp::Size instead of a wxSize.

2 months agoReset _next_video_time when deciding to emit black.
Carl Hetherington [Sun, 18 Feb 2024 22:36:10 +0000 (23:36 +0100)]
Reset _next_video_time when deciding to emit black.

Otherwise if we inaccurately seek into an area with no video there
will never be any content coming into ::video() which could reset
_next_video_time. Then when a black frame is emitted using
emit_video_until we will emit black frames from time 0 to the time
of the inaccurate seek.

2 months agoAdd some more logs to the LOG_DEBUG_PLAYER set.
Carl Hetherington [Sun, 18 Feb 2024 22:34:48 +0000 (23:34 +0100)]
Add some more logs to the LOG_DEBUG_PLAYER set.

2 months agoCleanup: use auto.
Carl Hetherington [Sun, 18 Feb 2024 22:34:26 +0000 (23:34 +0100)]
Cleanup: use auto.

2 months agoMerge tag 'v2.16.76' into v2.17.x
Carl Hetherington [Sun, 18 Feb 2024 23:56:14 +0000 (00:56 +0100)]
Merge tag 'v2.16.76' into v2.17.x

2 months agoFix note about branch handling.
Carl Hetherington [Sat, 17 Feb 2024 23:37:47 +0000 (00:37 +0100)]
Fix note about branch handling.

2 months agoAdd film duration to --dump output (#1702).
Carl Hetherington [Sat, 17 Feb 2024 23:32:37 +0000 (00:32 +0100)]
Add film duration to --dump output (#1702).

2 months agoAvoid quotation marks around dumped paths.
Carl Hetherington [Sat, 17 Feb 2024 23:32:13 +0000 (00:32 +0100)]
Avoid quotation marks around dumped paths.

2 months agoAdd option to load prefs from ZIP (#2771).
Carl Hetherington [Thu, 15 Feb 2024 00:05:22 +0000 (01:05 +0100)]
Add option to load prefs from ZIP (#2771).

2 months agoUse FileDialog for saving preferences ZIPs.
Carl Hetherington [Sat, 17 Feb 2024 22:45:23 +0000 (23:45 +0100)]
Use FileDialog for saving preferences ZIPs.

2 months agoCleanup: 0 -> nullptr.
Carl Hetherington [Sat, 17 Feb 2024 22:44:55 +0000 (23:44 +0100)]
Cleanup: 0 -> nullptr.

2 months agoReturn empty optional rather than asserting.
Carl Hetherington [Fri, 16 Feb 2024 22:46:27 +0000 (23:46 +0100)]
Return empty optional rather than asserting.

2 months agoCleanup: add missing explicit.
Carl Hetherington [Thu, 15 Feb 2024 00:05:17 +0000 (01:05 +0100)]
Cleanup: add missing explicit.

2 months agoAdd Unzipper.
Carl Hetherington [Thu, 15 Feb 2024 00:05:12 +0000 (01:05 +0100)]
Add Unzipper.

2 months agoSupporters update. v2.16.76
Carl Hetherington [Thu, 15 Feb 2024 23:36:03 +0000 (00:36 +0100)]
Supporters update.

2 months agoSupporters update.
Carl Hetherington [Thu, 15 Feb 2024 00:06:16 +0000 (01:06 +0100)]
Supporters update.

2 months agoBump libdcp for fix to error about unknown asset type.
Carl Hetherington [Wed, 14 Feb 2024 22:52:29 +0000 (23:52 +0100)]
Bump libdcp for fix to error about unknown asset type.

2 months agoFix conversion of _X to underlined X with GTK (via gtk_label_set_text_with_mnemonic...
Carl Hetherington [Wed, 14 Feb 2024 22:03:24 +0000 (23:03 +0100)]
Fix conversion of _X to underlined X with GTK (via gtk_label_set_text_with_mnemonic, I think).

2 months agoCleanup: white space.
Carl Hetherington [Wed, 14 Feb 2024 22:02:53 +0000 (23:02 +0100)]
Cleanup: white space.

2 months agoCope with loading a film containing a missing DCP which itself contains subtitles.
Carl Hetherington [Wed, 14 Feb 2024 22:02:48 +0000 (23:02 +0100)]
Cope with loading a film containing a missing DCP which itself contains subtitles.

2 months agoFix exception when calling resume() without first calling suspend().
Carl Hetherington [Wed, 14 Feb 2024 21:42:35 +0000 (22:42 +0100)]
Fix exception when calling resume() without first calling suspend().

3 months agoFix duplicated help text.
Carl Hetherington [Tue, 13 Feb 2024 21:21:57 +0000 (22:21 +0100)]
Fix duplicated help text.

3 months agoMerge branch 'main' into v2.17.x
Carl Hetherington [Mon, 12 Feb 2024 21:56:33 +0000 (22:56 +0100)]
Merge branch 'main' into v2.17.x

3 months agoFix message for high bitrate frames during verify.
Carl Hetherington [Mon, 12 Feb 2024 19:53:42 +0000 (20:53 +0100)]
Fix message for high bitrate frames during verify.

3 months agoMerge branch 'main' into v2.17.x
Carl Hetherington [Sun, 11 Feb 2024 23:06:13 +0000 (00:06 +0100)]
Merge branch 'main' into v2.17.x

3 months agoDon't add a font with an empty ID for ccaps either (#2762).
Carl Hetherington [Sun, 11 Feb 2024 19:13:04 +0000 (20:13 +0100)]
Don't add a font with an empty ID for ccaps either (#2762).

Previously this was all changed so that for subs we add the default
font in a cleaner way (in db22f81ccce9e1a5f205e6d8b3c0631fc039a173).

I can't see why we shouldn't treat ccaps the same way, and indeed
not doing it causes an error as shown by the included test.

3 months agoSupporters update.
Carl Hetherington [Sun, 11 Feb 2024 21:58:25 +0000 (22:58 +0100)]
Supporters update.

3 months agoFix apparently ineffective processors when analysing audio (#2671).
Carl Hetherington [Sun, 11 Feb 2024 12:10:48 +0000 (13:10 +0100)]
Fix apparently ineffective processors when analysing audio (#2671).

A whole film ("DCP side") analysis would behave the same as a
single piece of content analysis if the film only had one piece
of content.

Here we also clarify that audio analysis of the whole film is different
to that for a single piece of content; for the whole film we use processors,
and for single pieces of content we do not.

3 months agoAdd option to stop the player using any audio processor.
Carl Hetherington [Sun, 11 Feb 2024 12:09:30 +0000 (13:09 +0100)]
Add option to stop the player using any audio processor.

3 months agoAdd comment about AudioDialog.
Carl Hetherington [Sun, 11 Feb 2024 12:08:58 +0000 (13:08 +0100)]
Add comment about AudioDialog.

3 months agoFix totally missing saving of DKDM recipients.
Carl Hetherington [Sun, 11 Feb 2024 13:36:33 +0000 (14:36 +0100)]
Fix totally missing saving of DKDM recipients.

3 months agoRemove orphaned label.
Carl Hetherington [Sun, 11 Feb 2024 13:15:44 +0000 (14:15 +0100)]
Remove orphaned label.

3 months agoExtend the only column in the editable email address list.
Carl Hetherington [Sun, 11 Feb 2024 13:14:01 +0000 (14:14 +0100)]
Extend the only column in the editable email address list.

3 months agoUpdated sl_SI translation from Martin Srebotnjak.
Carl Hetherington [Sat, 10 Feb 2024 22:46:07 +0000 (23:46 +0100)]
Updated sl_SI translation from Martin Srebotnjak.

3 months agoAlso remove now-redundant UTC offset from DKDMRecipient.
Carl Hetherington [Sat, 10 Feb 2024 21:40:16 +0000 (22:40 +0100)]
Also remove now-redundant UTC offset from DKDMRecipient.

3 months agoAdd missing call to get_offsets().
Carl Hetherington [Sat, 10 Feb 2024 15:49:35 +0000 (16:49 +0100)]
Add missing call to get_offsets().

3 months agoSupporters update. v2.16.75
Carl Hetherington [Fri, 9 Feb 2024 12:07:43 +0000 (13:07 +0100)]
Supporters update.

3 months agoBump libdcp to fix time/date format bug.
Carl Hetherington [Fri, 9 Feb 2024 01:50:09 +0000 (02:50 +0100)]
Bump libdcp to fix time/date format bug.

3 months agoFix erroneously-moved warning removal (needed for Windows).
Carl Hetherington [Wed, 7 Feb 2024 23:36:52 +0000 (00:36 +0100)]
Fix erroneously-moved warning removal (needed for Windows).

3 months agoDon't give confusing errors about WEBVTT when there are errors in a Subrip file ...
Carl Hetherington [Tue, 6 Feb 2024 10:33:12 +0000 (11:33 +0100)]
Don't give confusing errors about WEBVTT when there are errors in a Subrip file (#2733).

3 months agoRemove apparently out-of-date comment.
Carl Hetherington [Tue, 6 Feb 2024 10:07:53 +0000 (11:07 +0100)]
Remove apparently out-of-date comment.

3 months agoRemove unused header.
Carl Hetherington [Tue, 6 Feb 2024 10:02:00 +0000 (11:02 +0100)]
Remove unused header.

3 months agoSimplify and improve performance of credits list.
Carl Hetherington [Tue, 30 Jan 2024 00:27:25 +0000 (01:27 +0100)]
Simplify and improve performance of credits list.

3 months ago3 columns in the about box looks better (especially on macOS).
Carl Hetherington [Tue, 30 Jan 2024 00:11:31 +0000 (01:11 +0100)]
3 columns in the about box looks better (especially on macOS).

3 months agoSome new warning-disable flags are not allowed with the 2.16.x Xcode.
Carl Hetherington [Mon, 5 Feb 2024 17:52:41 +0000 (18:52 +0100)]
Some new warning-disable flags are not allowed with the 2.16.x Xcode.

3 months agoAdd Benno Zwanenburg as a tester.
Carl Hetherington [Mon, 5 Feb 2024 12:11:09 +0000 (13:11 +0100)]
Add Benno Zwanenburg as a tester.

3 months agoAdd com.apple.security.cs.allow-unsigned-executable-memory (#2735).
Carl Hetherington [Tue, 30 Jan 2024 13:42:35 +0000 (14:42 +0100)]
Add com.apple.security.cs.allow-unsigned-executable-memory (#2735).

Tobi pointed out that the crashing thread crashes when trying to
execute the first instruction in the page

VM_ALLOCATE 119af0000-119af1000 [ 4K] r-x/rwx SM=PRV

which is dynamically allocated with VM_ALLOCATE (as opposed to being
a memory-mapped binary). Its protections (r-x/rwx) suggest that its
being used for JIT, so this code isn't signed, so the process
is killed by the hardened runtime.

We suspect FFmpeg is doing some JIT but perhaps only on x86_64
(as I couldn't reproduce the crash on arm64).

3 months agoMake default Disk Writer window a little narrower.
Carl Hetherington [Sat, 3 Feb 2024 00:20:08 +0000 (01:20 +0100)]
Make default Disk Writer window a little narrower.

3 months agoTweak labels: DCP -> DCPs.
Carl Hetherington [Sat, 3 Feb 2024 00:08:17 +0000 (01:08 +0100)]
Tweak labels: DCP -> DCPs.

3 months agoTweak vertical spacing of wxChoice on macOS (#2747).
Carl Hetherington [Fri, 2 Feb 2024 23:22:22 +0000 (00:22 +0100)]
Tweak vertical spacing of wxChoice on macOS (#2747).

3 months agoUse a simpler way to decide what devices we could write to on macOS.
Carl Hetherington [Sat, 3 Feb 2024 20:11:46 +0000 (21:11 +0100)]
Use a simpler way to decide what devices we could write to on macOS.

This basically involves the kDADiskDescriptionDeviceInternalKey,
kDADiskDescriptionMediaRemovableKey and kDADiskDescriptionMediaWritableKey
keys revealed by looking in

https://github.com/balena-io-modules/drivelist.git

3 months agoLook for drives for 3 seconds on startup (#2748).
Carl Hetherington [Sun, 4 Feb 2024 12:17:18 +0000 (13:17 +0100)]
Look for drives for 3 seconds on startup (#2748).

3 months agoMerge branch 'main' into v2.17.x
Carl Hetherington [Sun, 4 Feb 2024 12:03:45 +0000 (13:03 +0100)]
Merge branch 'main' into v2.17.x

3 months agoSuppress some warnings when building with Xcode 15.
Carl Hetherington [Sun, 4 Feb 2024 11:51:17 +0000 (12:51 +0100)]
Suppress some warnings when building with Xcode 15.

3 months agoTweak how lzma is linked.
Carl Hetherington [Sun, 4 Feb 2024 11:51:06 +0000 (12:51 +0100)]
Tweak how lzma is linked.

3 months agoAllow setting paths for a build with a workspace directory and a provided SDK, or...
Carl Hetherington [Sun, 4 Feb 2024 11:39:38 +0000 (12:39 +0100)]
Allow setting paths for a build with a workspace directory and a provided SDK, or the local default.

3 months agoDetect arch in set_paths.sh.
Carl Hetherington [Sun, 4 Feb 2024 11:33:36 +0000 (12:33 +0100)]
Detect arch in set_paths.sh.

3 months agoFix disk_writer startup script (I think) for mac.
Carl Hetherington [Sun, 4 Feb 2024 11:26:56 +0000 (12:26 +0100)]
Fix disk_writer startup script (I think) for mac.

3 months agoAdd DYLD_LIBRARY_PATH to dcpomatic_disk.
Carl Hetherington [Sun, 4 Feb 2024 11:25:41 +0000 (12:25 +0100)]
Add DYLD_LIBRARY_PATH to dcpomatic_disk.

3 months agoUse lldb on macOS.
Carl Hetherington [Sun, 4 Feb 2024 11:24:57 +0000 (12:24 +0100)]
Use lldb on macOS.

3 months agoAdd example ASAN_OPTIONS to script.
Carl Hetherington [Sun, 4 Feb 2024 11:23:44 +0000 (12:23 +0100)]
Add example ASAN_OPTIONS to script.

3 months agoAdd DYLD_LIBRARY_PATH to run/dcpomatic
Carl Hetherington [Sun, 4 Feb 2024 11:23:37 +0000 (12:23 +0100)]
Add DYLD_LIBRARY_PATH to run/dcpomatic

3 months agoMake set_paths.sh work on x86_64 and arm64.
Carl Hetherington [Sun, 4 Feb 2024 11:21:06 +0000 (12:21 +0100)]
Make set_paths.sh work on x86_64 and arm64.

3 months agoMerge branch 'main' into v2.17.x
Carl Hetherington [Sat, 3 Feb 2024 21:13:13 +0000 (22:13 +0100)]
Merge branch 'main' into v2.17.x

3 months agoSupporters update. v2.16.74
Carl Hetherington [Sat, 3 Feb 2024 09:19:22 +0000 (10:19 +0100)]
Supporters update.

3 months agoRemove unused variable.
Carl Hetherington [Fri, 2 Feb 2024 14:42:49 +0000 (15:42 +0100)]
Remove unused variable.

3 months agoDon't emit subtitle images that have a zero dimension (#2743).
Carl Hetherington [Thu, 1 Feb 2024 12:29:53 +0000 (13:29 +0100)]
Don't emit subtitle images that have a zero dimension (#2743).

They cause problems later when trying to blend them into the image.

3 months agoAdd an assert to check that sws_getContext() succeeded.
Carl Hetherington [Thu, 1 Feb 2024 12:28:49 +0000 (13:28 +0100)]
Add an assert to check that sws_getContext() succeeded.

3 months agoAdd some asserts; sws_getContext() will fail if the image width or height are 0.
Carl Hetherington [Thu, 1 Feb 2024 12:28:38 +0000 (13:28 +0100)]
Add some asserts; sws_getContext() will fail if the image width or height are 0.