dcpomatic.git
2 months agoSupporters update. v2.16.75
Carl Hetherington [Fri, 9 Feb 2024 12:07:43 +0000 (13:07 +0100)]
Supporters update.

2 months agoBump libdcp to fix time/date format bug.
Carl Hetherington [Fri, 9 Feb 2024 01:50:09 +0000 (02:50 +0100)]
Bump libdcp to fix time/date format bug.

2 months agoFix erroneously-moved warning removal (needed for Windows).
Carl Hetherington [Wed, 7 Feb 2024 23:36:52 +0000 (00:36 +0100)]
Fix erroneously-moved warning removal (needed for Windows).

2 months agoDon't give confusing errors about WEBVTT when there are errors in a Subrip file ...
Carl Hetherington [Tue, 6 Feb 2024 10:33:12 +0000 (11:33 +0100)]
Don't give confusing errors about WEBVTT when there are errors in a Subrip file (#2733).

2 months agoRemove apparently out-of-date comment.
Carl Hetherington [Tue, 6 Feb 2024 10:07:53 +0000 (11:07 +0100)]
Remove apparently out-of-date comment.

2 months agoRemove unused header.
Carl Hetherington [Tue, 6 Feb 2024 10:02:00 +0000 (11:02 +0100)]
Remove unused header.

2 months agoSimplify and improve performance of credits list.
Carl Hetherington [Tue, 30 Jan 2024 00:27:25 +0000 (01:27 +0100)]
Simplify and improve performance of credits list.

2 months ago3 columns in the about box looks better (especially on macOS).
Carl Hetherington [Tue, 30 Jan 2024 00:11:31 +0000 (01:11 +0100)]
3 columns in the about box looks better (especially on macOS).

2 months agoSome new warning-disable flags are not allowed with the 2.16.x Xcode.
Carl Hetherington [Mon, 5 Feb 2024 17:52:41 +0000 (18:52 +0100)]
Some new warning-disable flags are not allowed with the 2.16.x Xcode.

2 months agoAdd Benno Zwanenburg as a tester.
Carl Hetherington [Mon, 5 Feb 2024 12:11:09 +0000 (13:11 +0100)]
Add Benno Zwanenburg as a tester.

2 months agoAdd com.apple.security.cs.allow-unsigned-executable-memory (#2735).
Carl Hetherington [Tue, 30 Jan 2024 13:42:35 +0000 (14:42 +0100)]
Add com.apple.security.cs.allow-unsigned-executable-memory (#2735).

Tobi pointed out that the crashing thread crashes when trying to
execute the first instruction in the page

VM_ALLOCATE 119af0000-119af1000 [ 4K] r-x/rwx SM=PRV

which is dynamically allocated with VM_ALLOCATE (as opposed to being
a memory-mapped binary). Its protections (r-x/rwx) suggest that its
being used for JIT, so this code isn't signed, so the process
is killed by the hardened runtime.

We suspect FFmpeg is doing some JIT but perhaps only on x86_64
(as I couldn't reproduce the crash on arm64).

2 months agoSuppress some warnings when building with Xcode 15.
Carl Hetherington [Sun, 4 Feb 2024 11:51:17 +0000 (12:51 +0100)]
Suppress some warnings when building with Xcode 15.

2 months agoTweak how lzma is linked.
Carl Hetherington [Sun, 4 Feb 2024 11:51:06 +0000 (12:51 +0100)]
Tweak how lzma is linked.

2 months agoAllow setting paths for a build with a workspace directory and a provided SDK, or...
Carl Hetherington [Sun, 4 Feb 2024 11:39:38 +0000 (12:39 +0100)]
Allow setting paths for a build with a workspace directory and a provided SDK, or the local default.

2 months agoDetect arch in set_paths.sh.
Carl Hetherington [Sun, 4 Feb 2024 11:33:36 +0000 (12:33 +0100)]
Detect arch in set_paths.sh.

2 months agoFix disk_writer startup script (I think) for mac.
Carl Hetherington [Sun, 4 Feb 2024 11:26:56 +0000 (12:26 +0100)]
Fix disk_writer startup script (I think) for mac.

2 months agoAdd DYLD_LIBRARY_PATH to dcpomatic_disk.
Carl Hetherington [Sun, 4 Feb 2024 11:25:41 +0000 (12:25 +0100)]
Add DYLD_LIBRARY_PATH to dcpomatic_disk.

2 months agoUse lldb on macOS.
Carl Hetherington [Sun, 4 Feb 2024 11:24:57 +0000 (12:24 +0100)]
Use lldb on macOS.

2 months agoAdd example ASAN_OPTIONS to script.
Carl Hetherington [Sun, 4 Feb 2024 11:23:44 +0000 (12:23 +0100)]
Add example ASAN_OPTIONS to script.

2 months agoAdd DYLD_LIBRARY_PATH to run/dcpomatic
Carl Hetherington [Sun, 4 Feb 2024 11:23:37 +0000 (12:23 +0100)]
Add DYLD_LIBRARY_PATH to run/dcpomatic

2 months agoMake set_paths.sh work on x86_64 and arm64.
Carl Hetherington [Sun, 4 Feb 2024 11:21:06 +0000 (12:21 +0100)]
Make set_paths.sh work on x86_64 and arm64.

2 months agoSupporters update. v2.16.74
Carl Hetherington [Sat, 3 Feb 2024 09:19:22 +0000 (10:19 +0100)]
Supporters update.

2 months agoRemove unused variable.
Carl Hetherington [Fri, 2 Feb 2024 14:42:49 +0000 (15:42 +0100)]
Remove unused variable.

2 months agoDon't emit subtitle images that have a zero dimension (#2743).
Carl Hetherington [Thu, 1 Feb 2024 12:29:53 +0000 (13:29 +0100)]
Don't emit subtitle images that have a zero dimension (#2743).

They cause problems later when trying to blend them into the image.

2 months agoAdd an assert to check that sws_getContext() succeeded.
Carl Hetherington [Thu, 1 Feb 2024 12:28:49 +0000 (13:28 +0100)]
Add an assert to check that sws_getContext() succeeded.

2 months agoAdd some asserts; sws_getContext() will fail if the image width or height are 0.
Carl Hetherington [Thu, 1 Feb 2024 12:28:38 +0000 (13:28 +0100)]
Add some asserts; sws_getContext() will fail if the image width or height are 0.

2 months agoSupport alpha blend onto YUV444P9LE and YUV444P10LE (68 and 70).
Carl Hetherington [Mon, 29 Jan 2024 11:43:08 +0000 (12:43 +0100)]
Support alpha blend onto YUV444P9LE and YUV444P10LE (68 and 70).

2 months agoFix incorrect pixel formats for tests.
Carl Hetherington [Mon, 29 Jan 2024 11:41:48 +0000 (12:41 +0100)]
Fix incorrect pixel formats for tests.

2 months agoFix flipped red and blue with rgba64_onto_* tests.
Carl Hetherington [Mon, 29 Jan 2024 11:41:29 +0000 (12:41 +0100)]
Fix flipped red and blue with rgba64_onto_* tests.

2 months agoFix incorrect alpha channel scaling with RGBA64.
Carl Hetherington [Mon, 29 Jan 2024 11:16:55 +0000 (12:16 +0100)]
Fix incorrect alpha channel scaling with RGBA64.

2 months agoFix incorrect alpha step used for RGBA64 sources.
Carl Hetherington [Mon, 29 Jan 2024 10:38:39 +0000 (11:38 +0100)]
Fix incorrect alpha step used for RGBA64 sources.

2 months agoPut alpha_{data,stride} into OtherYUVParams.
Carl Hetherington [Mon, 29 Jan 2024 10:36:10 +0000 (11:36 +0100)]
Put alpha_{data,stride} into OtherYUVParams.

2 months agoSeparate out OtherParams into Other{RGB,YUV}Params.
Carl Hetherington [Mon, 29 Jan 2024 10:31:30 +0000 (11:31 +0100)]
Separate out OtherParams into Other{RGB,YUV}Params.

2 months agoOSX -> macOS
Carl Hetherington [Fri, 2 Feb 2024 23:09:14 +0000 (00:09 +0100)]
OSX -> macOS

3 months agoFix error when opening the right-click content menu.
Carl Hetherington [Thu, 1 Feb 2024 11:28:39 +0000 (12:28 +0100)]
Fix error when opening the right-click content menu.

3 months agoAdd --enable-asan option to configure.
Carl Hetherington [Thu, 1 Feb 2024 00:09:04 +0000 (01:09 +0100)]
Add --enable-asan option to configure.

3 months agoAdd some more space for macOS preferences icons.
Carl Hetherington [Thu, 1 Feb 2024 00:03:13 +0000 (01:03 +0100)]
Add some more space for macOS preferences icons.

3 months agoTweak macOS preferences icons (#2746).
Carl Hetherington [Wed, 31 Jan 2024 23:58:48 +0000 (00:58 +0100)]
Tweak macOS preferences icons (#2746).

3 months agoOpen macOS prefs with Mac-, not Mac-P (#2745).
Carl Hetherington [Tue, 30 Jan 2024 18:31:13 +0000 (19:31 +0100)]
Open macOS prefs with Mac-, not Mac-P (#2745).

3 months agoSupporters update. v2.16.73
Carl Hetherington [Sat, 27 Jan 2024 23:30:00 +0000 (00:30 +0100)]
Supporters update.

3 months agoFix assertion on trying to select a file (#2737).
Carl Hetherington [Fri, 26 Jan 2024 22:46:57 +0000 (23:46 +0100)]
Fix assertion on trying to select a file (#2737).

3 months agoAdd supporters. v2.16.72
Carl Hetherington [Tue, 23 Jan 2024 20:04:41 +0000 (21:04 +0100)]
Add supporters.

3 months agoRemove unused variables.
Carl Hetherington [Sun, 21 Jan 2024 01:23:58 +0000 (02:23 +0100)]
Remove unused variables.

3 months agoExplicitly link zlib to keep new macOS environment happy.
Carl Hetherington [Sat, 20 Jan 2024 15:50:38 +0000 (16:50 +0100)]
Explicitly link zlib to keep new macOS environment happy.

3 months agoBuild fix for HAVE_AVSUBTITLERECT_PICT case.
Carl Hetherington [Sat, 20 Jan 2024 15:20:50 +0000 (16:20 +0100)]
Build fix for HAVE_AVSUBTITLERECT_PICT case.

3 months agoRemove unused variable.
Carl Hetherington [Sat, 20 Jan 2024 14:50:33 +0000 (15:50 +0100)]
Remove unused variable.

3 months agomacOS build fix.
Carl Hetherington [Thu, 18 Jan 2024 09:05:31 +0000 (10:05 +0100)]
macOS build fix.

3 months agoAllow specification of KDM annotation text (#296).
Carl Hetherington [Wed, 17 Jan 2024 23:58:51 +0000 (00:58 +0100)]
Allow specification of KDM annotation text (#296).

3 months agoTweak layout.
Carl Hetherington [Wed, 17 Jan 2024 23:05:28 +0000 (00:05 +0100)]
Tweak layout.

3 months agoFix ISDCF name when referring to OVs with subs (#2703).
Carl Hetherington [Wed, 17 Jan 2024 22:46:26 +0000 (23:46 +0100)]
Fix ISDCF name when referring to OVs with subs (#2703).

3 months agoMove burnt subtitle checks into ::subtitle_languages().
Carl Hetherington [Wed, 17 Jan 2024 22:41:23 +0000 (23:41 +0100)]
Move burnt subtitle checks into ::subtitle_languages().

3 months agoCleanup: forward declaration sorting.
Carl Hetherington [Wed, 17 Jan 2024 22:34:08 +0000 (23:34 +0100)]
Cleanup: forward declaration sorting.

3 months agoBump libsub for Arch build fix (#2731).
Carl Hetherington [Tue, 16 Jan 2024 21:00:29 +0000 (22:00 +0100)]
Bump libsub for Arch build fix (#2731).

3 months agoRemember some more paths when selecting files (#2728).
Carl Hetherington [Tue, 16 Jan 2024 00:44:49 +0000 (01:44 +0100)]
Remember some more paths when selecting files (#2728).

* export subtitles
* export video
* debug log
* cinema database
* config file

3 months agoCleanup: remove some make_wx<> that aren't needed.
Carl Hetherington [Tue, 16 Jan 2024 20:28:37 +0000 (21:28 +0100)]
Cleanup: remove some make_wx<> that aren't needed.

3 months agoAdd some comments.
Carl Hetherington [Mon, 15 Jan 2024 23:47:39 +0000 (00:47 +0100)]
Add some comments.

3 months agoCleanup: rename some methods in FilePickerCtrl and use boost::filesystem::path more.
Carl Hetherington [Mon, 15 Jan 2024 23:33:05 +0000 (00:33 +0100)]
Cleanup: rename some methods in FilePickerCtrl and use boost::filesystem::path more.

3 months agoMissing include.
Carl Hetherington [Tue, 16 Jan 2024 15:50:23 +0000 (16:50 +0100)]
Missing include.

3 months agoInspect most DCPs made during tests with ClairMeta (#76).
Carl Hetherington [Fri, 12 Jan 2024 14:29:12 +0000 (15:29 +0100)]
Inspect most DCPs made during tests with ClairMeta (#76).

3 months agoInspect most DCPs made during tests with dcp_inspect (#76).
Carl Hetherington [Thu, 11 Jan 2024 15:24:38 +0000 (16:24 +0100)]
Inspect most DCPs made during tests with dcp_inspect (#76).

3 months agoMissing PRIVATE_GIT update from previous.
Carl Hetherington [Mon, 15 Jan 2024 09:25:14 +0000 (10:25 +0100)]
Missing PRIVATE_GIT update from previous.

3 months agoFix handling of empty font IDs and default DCP fonts (#2721) (part of #2722).
Carl Hetherington [Sat, 13 Jan 2024 22:34:35 +0000 (23:34 +0100)]
Fix handling of empty font IDs and default DCP fonts (#2721) (part of #2722).

Previously we used an empty font ID as the default for when a subtitle
has no Font, but in #2721 we saw a DCP with an empty font ID which
raised an assertion (because we'd already added our default font with
the empty ID).

Here we try to fix this (and also make the default font correctly be
that from the first <LoadFont>).

3 months agoIncrease timeout before pulsing the progress bar for a job.
Carl Hetherington [Sun, 14 Jan 2024 23:48:43 +0000 (00:48 +0100)]
Increase timeout before pulsing the progress bar for a job.

3 months agoAdd an assert.
Carl Hetherington [Sat, 13 Jan 2024 20:52:27 +0000 (21:52 +0100)]
Add an assert.

3 months agoShow hashes when they disagree during verification (#2717).
Carl Hetherington [Sat, 13 Jan 2024 00:01:09 +0000 (01:01 +0100)]
Show hashes when they disagree during verification (#2717).

3 months agoUpdated nl_NL translation from Rob van Nieuwkerk.
Carl Hetherington [Fri, 12 Jan 2024 23:13:17 +0000 (00:13 +0100)]
Updated nl_NL translation from Rob van Nieuwkerk.

3 months agoFix scaling of bitmap subs when the corresponding video is cropped (#2670).
Carl Hetherington [Fri, 1 Dec 2023 20:25:54 +0000 (21:25 +0100)]
Fix scaling of bitmap subs when the corresponding video is cropped (#2670).

Previously we would scale the bitmap size/position to a proportion
of the original video frame, then scale it back up again to the DCP
container.  This didn't take into account some cropped cases where
the picture would end up the same shape but the subtitles would be
stretched.

3 months agopot/merge.
Carl Hetherington [Thu, 11 Jan 2024 23:55:10 +0000 (00:55 +0100)]
pot/merge.

3 months agoFix markers view for RTL languages (part of #2696).
Carl Hetherington [Thu, 11 Jan 2024 21:51:23 +0000 (22:51 +0100)]
Fix markers view for RTL languages (part of #2696).

3 months agoFix "add" markers submenu for the last couple of markers.
Carl Hetherington [Thu, 11 Jan 2024 21:51:00 +0000 (22:51 +0100)]
Fix "add" markers submenu for the last couple of markers.

3 months agoAttempt to rationalise menu IDs and avoid duplicates.
Carl Hetherington [Thu, 11 Jan 2024 21:50:29 +0000 (22:50 +0100)]
Attempt to rationalise menu IDs and avoid duplicates.

3 months agoCleanup: using/include sorting.
Carl Hetherington [Thu, 11 Jan 2024 21:49:32 +0000 (22:49 +0100)]
Cleanup: using/include sorting.

3 months agoFix timecode order in RTL languages (part of #2696).
Carl Hetherington [Thu, 11 Jan 2024 20:02:11 +0000 (21:02 +0100)]
Fix timecode order in RTL languages (part of #2696).

3 months agoSupporters update.
Carl Hetherington [Thu, 11 Jan 2024 19:37:57 +0000 (20:37 +0100)]
Supporters update.

3 months agoUpdated fa_IR translation from Soleyman Rahmani.
Carl Hetherington [Thu, 11 Jan 2024 19:24:21 +0000 (20:24 +0100)]
Updated fa_IR translation from Soleyman Rahmani.

3 months agoMore test fixes after changes in c2c6fbdd8dddbb6ccba0a6ae49a13d5364122df7
Carl Hetherington [Thu, 11 Jan 2024 16:08:05 +0000 (17:08 +0100)]
More test fixes after changes in c2c6fbdd8dddbb6ccba0a6ae49a13d5364122df7

3 months agoFix tests after changes in c2c6fbdd8dddbb6ccba0a6ae49a13d5364122df7
Carl Hetherington [Thu, 11 Jan 2024 11:04:48 +0000 (12:04 +0100)]
Fix tests after changes in c2c6fbdd8dddbb6ccba0a6ae49a13d5364122df7

3 months agoReduce minimum "non-standard" ISDCF part name length to 1.
Carl Hetherington [Thu, 11 Jan 2024 10:28:24 +0000 (11:28 +0100)]
Reduce minimum "non-standard" ISDCF part name length to 1.

Otherwise on macOS (at least) you can't type in any numbers, seemingly because
it checks on each keypress so e.g. you clear it, enter 1 and a bell rings because
1 is too small.  It's fine on Linux (a too-small number is corrected when you
press enter).

3 months agoFix crash when changing ISDCF name part length (#2690).
Carl Hetherington [Wed, 10 Jan 2024 22:49:18 +0000 (23:49 +0100)]
Fix crash when changing ISDCF name part length (#2690).

3 months agoMark a VF as having assets, even if they are unresolved (#1024).
Carl Hetherington [Wed, 10 Jan 2024 16:47:32 +0000 (17:47 +0100)]
Mark a VF as having assets, even if they are unresolved (#1024).

This allows them to be displayed in the timeline, hopefully without
any unwanted side-effects.

3 months agoRe-make video after YUV/RGB matrix is changed (#2714).
Carl Hetherington [Tue, 9 Jan 2024 12:02:09 +0000 (13:02 +0100)]
Re-make video after YUV/RGB matrix is changed (#2714).

3 months agoCleanup: white space.
Carl Hetherington [Tue, 9 Jan 2024 12:01:50 +0000 (13:01 +0100)]
Cleanup: white space.

3 months agoCheck for bad DN qualifiers on signer certificates (#2716).
Carl Hetherington [Mon, 8 Jan 2024 18:01:21 +0000 (19:01 +0100)]
Check for bad DN qualifiers on signer certificates (#2716).

3 months agoMove ScopeGuard into libdcp.
Carl Hetherington [Mon, 8 Jan 2024 15:25:42 +0000 (16:25 +0100)]
Move ScopeGuard into libdcp.

3 months agoUpdated fa_IR translation from Soleyman Rahmani.
Carl Hetherington [Sun, 7 Jan 2024 23:51:45 +0000 (00:51 +0100)]
Updated fa_IR translation from Soleyman Rahmani.

3 months agoCleanup: remove unused method.
Carl Hetherington [Fri, 5 Jan 2024 00:38:50 +0000 (01:38 +0100)]
Cleanup: remove unused method.

3 months agoDon't use video streams with AV_DISPOSITION_ATTACHED_PIC (#2349).
Carl Hetherington [Thu, 4 Jan 2024 22:58:56 +0000 (23:58 +0100)]
Don't use video streams with AV_DISPOSITION_ATTACHED_PIC (#2349).

These are seen in MP3 files for cover art.

3 months agoAdd new "territory type" so that INT-T{D,L} can be chosen (#2704).
Carl Hetherington [Fri, 5 Jan 2024 00:28:19 +0000 (01:28 +0100)]
Add new "territory type" so that INT-T{D,L} can be chosen (#2704).

3 months agoAdd Choice::set_by_data().
Carl Hetherington [Fri, 5 Jan 2024 00:26:58 +0000 (01:26 +0100)]
Add Choice::set_by_data().

3 months agoRemove out-of-date patrons.
Carl Hetherington [Fri, 5 Jan 2024 00:52:47 +0000 (01:52 +0100)]
Remove out-of-date patrons.

3 months agoCleanup: longer variable name.
Carl Hetherington [Thu, 4 Jan 2024 22:56:04 +0000 (23:56 +0100)]
Cleanup: longer variable name.

3 months agoMerge branch '2694-remove-odd-check'
Carl Hetherington [Thu, 4 Jan 2024 22:37:15 +0000 (23:37 +0100)]
Merge branch '2694-remove-odd-check'

Allow referring to OVs where not every reel has a subtitle/ccap,
fixing it if required by adding our own reels.

3 months agoAdd a test.
Carl Hetherington [Thu, 28 Dec 2023 23:06:54 +0000 (00:06 +0100)]
Add a test.

3 months agoAdd dummy subtitle and closed caption reels even when referencing
Carl Hetherington [Wed, 3 Jan 2024 23:40:03 +0000 (00:40 +0100)]
Add dummy subtitle and closed caption reels even when referencing
other DCPs (in a VF) that themselves might have missing subtitles
for some reels.

3 months agoFix libdcp to not crash in some VF verification situations.
Carl Hetherington [Fri, 29 Dec 2023 00:31:47 +0000 (01:31 +0100)]
Fix libdcp to not crash in some VF verification situations.

3 months agoDon't try to add fonts from an asset that we don't have.
Carl Hetherington [Fri, 29 Dec 2023 00:30:22 +0000 (01:30 +0100)]
Don't try to add fonts from an asset that we don't have.

3 months agoDon't add an asset that we don't have.
Carl Hetherington [Fri, 29 Dec 2023 00:30:09 +0000 (01:30 +0100)]
Don't add an asset that we don't have.

3 months agoDon't crash when checking a DCP with no subtitles in some reel.
Carl Hetherington [Mon, 25 Dec 2023 00:12:49 +0000 (01:12 +0100)]
Don't crash when checking a DCP with no subtitles in some reel.

3 months agoRemove checks for referenced DCPs having content in all reels (#2694).
Carl Hetherington [Sat, 23 Dec 2023 18:45:05 +0000 (19:45 +0100)]
Remove checks for referenced DCPs having content in all reels (#2694).

I can't see why this was done, other than perhaps to avoid output
with no subtitles in a reel (which is not allowed by Bv2.1).  But
I think even if that does still happen we could make our own reels
for the missing ones.

3 months agoAllow specification of map CPLs by ID (#2702).
Carl Hetherington [Thu, 4 Jan 2024 00:21:10 +0000 (01:21 +0100)]
Allow specification of map CPLs by ID (#2702).