dcpomatic.git
6 months agoUse dcp::filesystem to wrap filesystem calls and fix_long_path 2623-add-windows
Carl Hetherington [Fri, 6 Oct 2023 00:37:16 +0000 (02:37 +0200)]
Use dcp::filesystem to wrap filesystem calls and fix_long_path
anything that is passed to read_file() from libcxml.

This should fix #2623 and other similar problems.

6 months agoFIXME: Bump libdcp for new filesystem wrappers.
Carl Hetherington [Wed, 4 Oct 2023 22:20:27 +0000 (00:20 +0200)]
FIXME: Bump libdcp for new filesystem wrappers.

6 months agoBump leqm-nrt to build with -O2 for a large speed-up (#2616).
Carl Hetherington [Sun, 8 Oct 2023 21:04:59 +0000 (23:04 +0200)]
Bump leqm-nrt to build with -O2 for a large speed-up (#2616).

6 months agoFix flickering timeline drags on Windows (#2625).
Carl Hetherington [Wed, 4 Oct 2023 23:17:16 +0000 (01:17 +0200)]
Fix flickering timeline drags on Windows (#2625).

6 months agoYou are advised -> It is advisable (#2189).
Carl Hetherington [Mon, 2 Oct 2023 21:41:06 +0000 (23:41 +0200)]
You are advised -> It is advisable (#2189).

6 months agoCleanup: use a lambda.
Carl Hetherington [Sat, 30 Sep 2023 20:58:45 +0000 (22:58 +0200)]
Cleanup: use a lambda.

6 months agoFix test/data branching SNAFU.
Carl Hetherington [Sat, 30 Sep 2023 10:35:26 +0000 (12:35 +0200)]
Fix test/data branching SNAFU.

6 months agoAllow DCP content type from template to work.
Carl Hetherington [Sat, 30 Sep 2023 10:32:42 +0000 (12:32 +0200)]
Allow DCP content type from template to work.

6 months agoAllow SMPTE/interop setting from template to work.
Carl Hetherington [Sat, 30 Sep 2023 10:28:05 +0000 (12:28 +0200)]
Allow SMPTE/interop setting from template to work.

6 months agoAdd --no-encrypt with the same idea as the previous commit.
Carl Hetherington [Sat, 30 Sep 2023 10:09:00 +0000 (12:09 +0200)]
Add --no-encrypt with the same idea as the previous commit.

6 months agoAdd --twod option to create CLI and stop 2D from being forced over
Carl Hetherington [Sat, 30 Sep 2023 09:58:29 +0000 (11:58 +0200)]
Add --twod option to create CLI and stop 2D from being forced over
a template if --threed is not specified (#2620/GH#22).

6 months agoCleanup: add some _ prefixes.
Carl Hetherington [Sat, 30 Sep 2023 09:42:26 +0000 (11:42 +0200)]
Cleanup: add some _ prefixes.

6 months agoCleanup: make some variables private.
Carl Hetherington [Sat, 30 Sep 2023 09:37:34 +0000 (11:37 +0200)]
Cleanup: make some variables private.

6 months agoCleanup: extract some stuff to a method in CreateCLI.
Carl Hetherington [Sat, 30 Sep 2023 09:29:42 +0000 (11:29 +0200)]
Cleanup: extract some stuff to a method in CreateCLI.

6 months agoApply video range from template (#2611).
Carl Hetherington [Sat, 30 Sep 2023 08:43:15 +0000 (10:43 +0200)]
Apply video range from template (#2611).

6 months agoSupport alpha blending 64-bit RGB onto things.
Carl Hetherington [Thu, 28 Sep 2023 20:18:34 +0000 (22:18 +0200)]
Support alpha blending 64-bit RGB onto things.

6 months agoRename alpha_blend_test_one -> alpha_blend_test_bgra_onto.
Carl Hetherington [Wed, 27 Sep 2023 22:00:15 +0000 (00:00 +0200)]
Rename alpha_blend_test_one -> alpha_blend_test_bgra_onto.

6 months agoCleanup: extract some parts of alpha_blend().
Carl Hetherington [Sun, 24 Sep 2023 22:38:10 +0000 (00:38 +0200)]
Cleanup: extract some parts of alpha_blend().

6 months agoFix errors with WAVs containing markers (#2617).
Carl Hetherington [Tue, 26 Sep 2023 22:16:38 +0000 (00:16 +0200)]
Fix errors with WAVs containing markers (#2617).

I'm not 100% sure about this but they seem to end up giving audio
packets with no channels and no frames.  Here we handle such packets
better.

6 months agoInstall for all users on Windows (#2202).
Carl Hetherington [Thu, 28 Sep 2023 19:02:44 +0000 (21:02 +0200)]
Install for all users on Windows (#2202).

7 months agoAdd some new pixfmts.
Carl Hetherington [Sun, 24 Sep 2023 21:30:19 +0000 (23:30 +0200)]
Add some new pixfmts.

7 months agoClean up and add Ubuntu 23.10
Carl Hetherington [Thu, 21 Sep 2023 21:58:49 +0000 (23:58 +0200)]
Clean up and add Ubuntu 23.10

7 months agoSupporters update. v2.16.65
Carl Hetherington [Wed, 20 Sep 2023 23:10:14 +0000 (01:10 +0200)]
Supporters update.

7 months agoFix example names in prefs (#2612).
Carl Hetherington [Wed, 20 Sep 2023 21:59:20 +0000 (23:59 +0200)]
Fix example names in prefs (#2612).

7 months agoBetter error message.
Carl Hetherington [Wed, 20 Sep 2023 20:57:03 +0000 (22:57 +0200)]
Better error message.

7 months agoUpdated zh_CN translation from poppinzhang.
Carl Hetherington [Fri, 15 Sep 2023 08:53:33 +0000 (10:53 +0200)]
Updated zh_CN translation from poppinzhang.

7 months agoUpdated sl_SI translation from Martin Srebotnjak.
Carl Hetherington [Thu, 14 Sep 2023 21:12:19 +0000 (23:12 +0200)]
Updated sl_SI translation from Martin Srebotnjak.

7 months agoSupporters update.
Carl Hetherington [Thu, 14 Sep 2023 08:57:18 +0000 (10:57 +0200)]
Supporters update.

7 months agoSupporters update. v2.16.64
Carl Hetherington [Wed, 13 Sep 2023 21:27:39 +0000 (23:27 +0200)]
Supporters update.

7 months agoBump libdcp for fix to GH #20, a spurious rejection of a KDM.
Carl Hetherington [Wed, 13 Sep 2023 20:29:04 +0000 (22:29 +0200)]
Bump libdcp for fix to GH #20, a spurious rejection of a KDM.

7 months agoUpdate ISDCF name when DCP track changes.
Carl Hetherington [Tue, 12 Sep 2023 21:14:42 +0000 (23:14 +0200)]
Update ISDCF name when DCP track changes.

7 months agoSomewhat fix inclusion of CCAP language in ISDCF name (#2610).
Carl Hetherington [Tue, 12 Sep 2023 21:14:35 +0000 (23:14 +0200)]
Somewhat fix inclusion of CCAP language in ISDCF name (#2610).

7 months agoAdd Film::closed_caption_languages().
Carl Hetherington [Tue, 12 Sep 2023 21:14:06 +0000 (23:14 +0200)]
Add Film::closed_caption_languages().

7 months agoUpdate DCP name when some text changes from subtitle to ccap.
Carl Hetherington [Mon, 11 Sep 2023 22:36:05 +0000 (00:36 +0200)]
Update DCP name when some text changes from subtitle to ccap.

7 months agoAlways add -CCAP to ISDCF names if there are ccaps.
Carl Hetherington [Mon, 11 Sep 2023 22:35:39 +0000 (00:35 +0200)]
Always add -CCAP to ISDCF names if there are ccaps.

7 months agoCleanup: use some stack allocation and shared_ptr.
Carl Hetherington [Sun, 10 Sep 2023 20:14:58 +0000 (22:14 +0200)]
Cleanup: use some stack allocation and shared_ptr.

7 months agoAlways call AddCatalog("wxstd") as it appears to be necessary to
Carl Hetherington [Fri, 8 Sep 2023 22:01:35 +0000 (00:01 +0200)]
Always call AddCatalog("wxstd") as it appears to be necessary to
get wxWidgets' translations to appear (at least on Windows) (#2606).

7 months agoOpen Windows console earlier in startup.
Carl Hetherington [Fri, 8 Sep 2023 22:00:26 +0000 (00:00 +0200)]
Open Windows console earlier in startup.

7 months agoFix hints test now that subtitle reader gives an error on large fonts.
Carl Hetherington [Fri, 8 Sep 2023 05:47:41 +0000 (07:47 +0200)]
Fix hints test now that subtitle reader gives an error on large fonts.

7 months agoSanitise asset names after potentially failed %-based substitutions (#945).
Carl Hetherington [Thu, 7 Sep 2023 21:24:06 +0000 (23:24 +0200)]
Sanitise asset names after potentially failed %-based substitutions (#945).

If there's a %x in the format string, where %x is not recognised, we
should at least remove the %.

7 months agoDisallow % from asset names as it seems to awake some XML character-encoding
Carl Hetherington [Thu, 7 Sep 2023 21:22:54 +0000 (23:22 +0200)]
Disallow % from asset names as it seems to awake some XML character-encoding
demons.

7 months agoCleanup: use ConfigRestorer instead of Keep class.
Carl Hetherington [Thu, 7 Sep 2023 20:59:40 +0000 (22:59 +0200)]
Cleanup: use ConfigRestorer instead of Keep class.

7 months agoUpdated nl_NL translation from Rob van Nieuwkerk.
Carl Hetherington [Thu, 7 Sep 2023 12:37:34 +0000 (14:37 +0200)]
Updated nl_NL translation from Rob van Nieuwkerk.

7 months agoTry to allow staged and non-staged i18n updates.
Carl Hetherington [Thu, 7 Sep 2023 12:37:27 +0000 (14:37 +0200)]
Try to allow staged and non-staged i18n updates.

7 months agoBump libdcp to fix errors when loading DCPs with very big fonts.
Carl Hetherington [Wed, 6 Sep 2023 21:10:49 +0000 (23:10 +0200)]
Bump libdcp to fix errors when loading DCPs with very big fonts.

7 months agopot/merge.
Carl Hetherington [Tue, 5 Sep 2023 12:07:35 +0000 (14:07 +0200)]
pot/merge.

7 months agoUse configured issuer/creator for DCPs made by map (#2585).
Carl Hetherington [Mon, 4 Sep 2023 18:08:03 +0000 (20:08 +0200)]
Use configured issuer/creator for DCPs made by map (#2585).

7 months agoIgnore newlines in subtitle text (#2341).
Carl Hetherington [Fri, 16 Jun 2023 22:03:51 +0000 (00:03 +0200)]
Ignore newlines in subtitle text (#2341).

7 months agoFix rendering of italic fonts during tests on Windows.
Carl Hetherington [Sat, 2 Sep 2023 16:44:03 +0000 (18:44 +0200)]
Fix rendering of italic fonts during tests on Windows.

7 months agoFix crash when pressing Ctrl+{C,V} at the wrong time.
Carl Hetherington [Sat, 2 Sep 2023 20:32:06 +0000 (22:32 +0200)]
Fix crash when pressing Ctrl+{C,V} at the wrong time.

7 months agoSupporters update. v2.16.63
Carl Hetherington [Fri, 1 Sep 2023 17:32:46 +0000 (19:32 +0200)]
Supporters update.

7 months agoMissing #ifdef for Windows references.
Carl Hetherington [Fri, 1 Sep 2023 07:01:12 +0000 (09:01 +0200)]
Missing #ifdef for Windows references.

7 months agoSupporters update.
Carl Hetherington [Thu, 31 Aug 2023 22:09:47 +0000 (00:09 +0200)]
Supporters update.

7 months agoBump libdcp to release version.
Carl Hetherington [Thu, 31 Aug 2023 22:09:31 +0000 (00:09 +0200)]
Bump libdcp to release version.

7 months agoFix vertical alignment of subtitles in some cases (#2569).
Carl Hetherington [Sat, 26 Aug 2023 18:17:17 +0000 (20:17 +0200)]
Fix vertical alignment of subtitles in some cases (#2569).

7 months agoGive a more useful error when check_dcp() fails.
Carl Hetherington [Sat, 26 Aug 2023 18:16:47 +0000 (20:16 +0200)]
Give a more useful error when check_dcp() fails.

7 months agoFix incorrect horizontal positions when different HPositions are used with one VPosition.
Carl Hetherington [Sat, 26 Aug 2023 17:51:51 +0000 (19:51 +0200)]
Fix incorrect horizontal positions when different HPositions are used with one VPosition.

Previously if HPosition changed we would still use a single "line" (i.e. Pango layout)
for all the text, meaning that HPosition would not be respected.

7 months agoRestore burnt subtitle tests.
Carl Hetherington [Sat, 26 Aug 2023 17:49:25 +0000 (19:49 +0200)]
Restore burnt subtitle tests.

7 months agoCleanup: use some more vector instead of list.
Carl Hetherington [Sat, 26 Aug 2023 12:29:06 +0000 (14:29 +0200)]
Cleanup: use some more vector instead of list.

8 months agoFix tests when changing the cinemas file.
Carl Hetherington [Sat, 26 Aug 2023 17:45:02 +0000 (19:45 +0200)]
Fix tests when changing the cinemas file.

8 months agoHandle fonts/subdirs correctly for CCAPs with _map (#2584).
Carl Hetherington [Thu, 24 Aug 2023 21:50:18 +0000 (23:50 +0200)]
Handle fonts/subdirs correctly for CCAPs with _map (#2584).

8 months agoBump libdcp to properly check for missing fonts in CCAP LoadFont tags.
Carl Hetherington [Thu, 24 Aug 2023 21:51:16 +0000 (23:51 +0200)]
Bump libdcp to properly check for missing fonts in CCAP LoadFont tags.

8 months agoFix refusal to reference overlapping but different text content (#2599).
Carl Hetherington [Sat, 26 Aug 2023 22:17:58 +0000 (00:17 +0200)]
Fix refusal to reference overlapping but different text content (#2599).

8 months agoTweak a message to be more grammatically correct.
Carl Hetherington [Sat, 26 Aug 2023 22:14:14 +0000 (00:14 +0200)]
Tweak a message to be more grammatically correct.

8 months agoCleanup: use some lambdas.
Carl Hetherington [Sat, 26 Aug 2023 21:34:19 +0000 (23:34 +0200)]
Cleanup: use some lambdas.

8 months agoUpdate test/data for missing test reference.
Carl Hetherington [Sat, 26 Aug 2023 11:10:34 +0000 (13:10 +0200)]
Update test/data for missing test reference.

8 months agoSet up packet duration correctly when encoding using FFmpeg (#2588).
Carl Hetherington [Thu, 24 Aug 2023 13:44:32 +0000 (15:44 +0200)]
Set up packet duration correctly when encoding using FFmpeg (#2588).

It seems strange that this is necessary (maybe I'm missing some
other way that the packet duration is supposed to be set up).

Without this, when the mov muxer writes the trak tags it uses an
incorrect length value because the length value is calculated
from trk->end_pts, which in turn is calculated from the last-seen
pts + the duration of the last packet.  If that packet is marked
as length 0 the length of the track is 1 frame short, so the export
is missing a frame.

8 months agoCheck a return value for error.
Carl Hetherington [Thu, 24 Aug 2023 13:44:11 +0000 (15:44 +0200)]
Check a return value for error.

8 months agoSpeculative fix to ensure correct freeing.
Carl Hetherington [Thu, 24 Aug 2023 13:43:54 +0000 (15:43 +0200)]
Speculative fix to ensure correct freeing.

8 months agoExtend run_ffprobe to allow arguments and capture of stdout.
Carl Hetherington [Thu, 24 Aug 2023 13:43:06 +0000 (15:43 +0200)]
Extend run_ffprobe to allow arguments and capture of stdout.

8 months agoTry to capture ffmpeg logs during tests.
Carl Hetherington [Thu, 24 Aug 2023 09:33:07 +0000 (11:33 +0200)]
Try to capture ffmpeg logs during tests.

8 months agoCleanup: extract TranscodeJob::frames_per_second().
Carl Hetherington [Fri, 25 Aug 2023 23:43:22 +0000 (01:43 +0200)]
Cleanup: extract TranscodeJob::frames_per_second().

8 months agoDon't bother reporting job durations less than 10s.
Carl Hetherington [Fri, 25 Aug 2023 23:32:13 +0000 (01:32 +0200)]
Don't bother reporting job durations less than 10s.

8 months agoUse _{start,finish}_time in TranscodeJob.
Carl Hetherington [Fri, 25 Aug 2023 23:14:20 +0000 (01:14 +0200)]
Use _{start,finish}_time in TranscodeJob.

8 months agoGive more details when jobs finish (#2572).
Carl Hetherington [Fri, 25 Aug 2023 22:38:17 +0000 (00:38 +0200)]
Give more details when jobs finish (#2572).

8 months agoAdd --cinemas-file option to KDM CLI.
Carl Hetherington [Thu, 24 Aug 2023 15:55:39 +0000 (17:55 +0200)]
Add --cinemas-file option to KDM CLI.

8 months agoReplace a couple of erroneous calls to exit() in kdm_cli.cc.
Carl Hetherington [Thu, 24 Aug 2023 15:55:24 +0000 (17:55 +0200)]
Replace a couple of erroneous calls to exit() in kdm_cli.cc.

8 months agoAdd some more detail to the KDM CLI help.
Carl Hetherington [Thu, 24 Aug 2023 15:54:57 +0000 (17:54 +0200)]
Add some more detail to the KDM CLI help.

8 months agoBump libdcp for subtitle alignment parsing fix (#2602).
Carl Hetherington [Tue, 22 Aug 2023 22:03:16 +0000 (00:03 +0200)]
Bump libdcp for subtitle alignment parsing fix (#2602).

8 months agoFixed libdcp reference to be a release.
Carl Hetherington [Tue, 22 Aug 2023 14:17:40 +0000 (16:17 +0200)]
Fixed libdcp reference to be a release.

8 months agoSupporters update. v2.16.62
Carl Hetherington [Sun, 20 Aug 2023 19:51:25 +0000 (21:51 +0200)]
Supporters update.

8 months agoAnother signed/unsigned mismatch.
Carl Hetherington [Sun, 20 Aug 2023 12:07:10 +0000 (14:07 +0200)]
Another signed/unsigned mismatch.

8 months agoFix unsigned/signed mismatch.
Carl Hetherington [Sat, 19 Aug 2023 23:53:19 +0000 (01:53 +0200)]
Fix unsigned/signed mismatch.

8 months agoYet more private file fixing.
Carl Hetherington [Sat, 19 Aug 2023 20:48:00 +0000 (22:48 +0200)]
Yet more private file fixing.

8 months agoMore private test files tinkering.
Carl Hetherington [Sat, 19 Aug 2023 18:35:07 +0000 (20:35 +0200)]
More private test files tinkering.

8 months agoPrivate test files repo change.
Carl Hetherington [Sat, 19 Aug 2023 16:18:46 +0000 (18:18 +0200)]
Private test files repo change.

8 months agoSupporters update.
Carl Hetherington [Sat, 19 Aug 2023 12:22:33 +0000 (14:22 +0200)]
Supporters update.

8 months agoBump libdcp for dcp::LocalTime format fix.
Carl Hetherington [Tue, 15 Aug 2023 16:33:52 +0000 (18:33 +0200)]
Bump libdcp for dcp::LocalTime format fix.

8 months agoCope with unexpected channel counts in data coming from audio decoders.
Carl Hetherington [Tue, 15 Aug 2023 13:46:41 +0000 (15:46 +0200)]
Cope with unexpected channel counts in data coming from audio decoders.

8 months agoAdd Resampler::channels().
Carl Hetherington [Tue, 15 Aug 2023 13:46:30 +0000 (15:46 +0200)]
Add Resampler::channels().

8 months agoAdd Audiobuffers::set_channels().
Carl Hetherington [Tue, 15 Aug 2023 13:46:19 +0000 (15:46 +0200)]
Add Audiobuffers::set_channels().

8 months agoCleanup: remove unused variable.
Carl Hetherington [Tue, 15 Aug 2023 13:11:49 +0000 (15:11 +0200)]
Cleanup: remove unused variable.

8 months agoRemove now-unnecessary assertion.
Carl Hetherington [Tue, 15 Aug 2023 13:02:29 +0000 (15:02 +0200)]
Remove now-unnecessary assertion.

Since e29ce33a36c2e20444d57196defc86d5072bce81 channels is the
number of channels in the frame, and also the number in data,
so we don't need to check this any more.

8 months agoBump ffmpeg to fix build on binutils >= 2.41 (currently in Debian unstable).
Carl Hetherington [Mon, 14 Aug 2023 20:55:44 +0000 (22:55 +0200)]
Bump ffmpeg to fix build on binutils >= 2.41 (currently in Debian unstable).

8 months agoAdd missing GUI message. v2.16.61
Carl Hetherington [Fri, 11 Aug 2023 23:06:15 +0000 (01:06 +0200)]
Add missing GUI message.

8 months agoBump ffmpeg for fix to EXR parsing with non-multiple-of-8 image sizes (#2508).
Carl Hetherington [Sun, 2 Jul 2023 21:24:24 +0000 (23:24 +0200)]
Bump ffmpeg for fix to EXR parsing with non-multiple-of-8 image sizes (#2508).

8 months agoSupporters update.
Carl Hetherington [Fri, 11 Aug 2023 22:49:29 +0000 (00:49 +0200)]
Supporters update.

8 months agoBump libdcp for verification of <LabelText> in <ContentVersion>
Carl Hetherington [Fri, 11 Aug 2023 22:22:14 +0000 (00:22 +0200)]
Bump libdcp for verification of <LabelText> in <ContentVersion>

8 months agoPrevent empty <LabelText> in <ContentVersion> (#2594).
Carl Hetherington [Fri, 11 Aug 2023 22:13:08 +0000 (00:13 +0200)]
Prevent empty <LabelText> in <ContentVersion> (#2594).

8 months agoFix tests on Windows.
Carl Hetherington [Thu, 10 Aug 2023 21:12:09 +0000 (23:12 +0200)]
Fix tests on Windows.