dcpomatic.git
23 months agoMake sure that crop preview rectangle is properly hidden when we close the auto crop... main-old
Carl Hetherington [Sun, 1 May 2022 17:35:26 +0000 (19:35 +0200)]
Make sure that crop preview rectangle is properly hidden when we close the auto crop dialog.

23 months agoFix the alignment of the current position in the playback controls.
Carl Hetherington [Sun, 1 May 2022 17:32:14 +0000 (19:32 +0200)]
Fix the alignment of the current position in the playback controls.

23 months agoMore Centos 7 fixes.
Carl Hetherington [Sat, 30 Apr 2022 21:53:39 +0000 (23:53 +0200)]
More Centos 7 fixes.

23 months agoFix build on Centos 7.
Carl Hetherington [Sat, 30 Apr 2022 21:10:49 +0000 (23:10 +0200)]
Fix build on Centos 7.

23 months agoRemove unused variable.
Carl Hetherington [Sat, 30 Apr 2022 21:10:00 +0000 (23:10 +0200)]
Remove unused variable.

23 months agoWe don't have python f-strings everywhere.
Carl Hetherington [Sat, 30 Apr 2022 20:15:17 +0000 (22:15 +0200)]
We don't have python f-strings everywhere.

23 months agoAdd editor to a few more missing places.
Carl Hetherington [Sat, 30 Apr 2022 19:21:27 +0000 (21:21 +0200)]
Add editor to a few more missing places.

23 months agoAdd a simple DCP editor.
Carl Hetherington [Fri, 22 Apr 2022 23:59:10 +0000 (01:59 +0200)]
Add a simple DCP editor.

23 months agoUse explicit parameters to the EditableList constructor, and allow
Carl Hetherington [Thu, 28 Apr 2022 20:16:31 +0000 (22:16 +0200)]
Use explicit parameters to the EditableList constructor, and allow
arbitrary new/edit/remove button combinations to be used.

23 months agoC++11 tidying.
Carl Hetherington [Thu, 28 Apr 2022 20:16:05 +0000 (22:16 +0200)]
C++11 tidying.

23 months agoFix (I think) some strange situations where ::get() on dialogs
Carl Hetherington [Thu, 28 Apr 2022 20:12:54 +0000 (22:12 +0200)]
Fix (I think) some strange situations where ::get() on dialogs
used by EditableList would return something that wasn't a optional<>
but would then get implicitly cast to one.  Now we have a static_assert
to check that the type is what we expect.

2 years agoHandle multiple bitmap subtitles at the same time correctly (#2239).
Carl Hetherington [Thu, 28 Apr 2022 12:00:07 +0000 (14:00 +0200)]
Handle multiple bitmap subtitles at the same time correctly (#2239).

Previously if there were two images at the same time we would start
them both, then the stop time would be set in the second one but
not the first.  This meant that the first one would hang around
forever.

2 years agoTidying.
Carl Hetherington [Thu, 28 Apr 2022 11:48:29 +0000 (13:48 +0200)]
Tidying.

2 years agoAllow ContentBitmapText to contain multiple BitmapText objects.
Carl Hetherington [Thu, 28 Apr 2022 11:47:57 +0000 (13:47 +0200)]
Allow ContentBitmapText to contain multiple BitmapText objects.

2 years agoImprove some variable names.
Carl Hetherington [Thu, 28 Apr 2022 07:54:48 +0000 (09:54 +0200)]
Improve some variable names.

2 years agoMake emit_bitmap_start take a ContentBitmapText.
Carl Hetherington [Thu, 28 Apr 2022 07:47:22 +0000 (09:47 +0200)]
Make emit_bitmap_start take a ContentBitmapText.

2 years agoFix Windows build.
Carl Hetherington [Fri, 22 Apr 2022 23:59:28 +0000 (01:59 +0200)]
Fix Windows build.

2 years agoAnd another missed warnings.h
Carl Hetherington [Fri, 22 Apr 2022 21:50:01 +0000 (23:50 +0200)]
And another missed warnings.h

2 years agoMissing warnings.h include fix.
Carl Hetherington [Fri, 22 Apr 2022 21:48:20 +0000 (23:48 +0200)]
Missing warnings.h include fix.

2 years agoImprove rejection of "crazy" frame rates (#2238).
Carl Hetherington [Fri, 22 Apr 2022 21:06:19 +0000 (23:06 +0200)]
Improve rejection of "crazy" frame rates (#2238).

Firstly, look for other video streams even if one is not suitable.
Secondly, ignore very low frame rates as well as very high ones.

2 years agoUse libdcp's warnings.h
Carl Hetherington [Fri, 22 Apr 2022 21:27:15 +0000 (23:27 +0200)]
Use libdcp's warnings.h

2 years agoclang does not have -Wsuggest-override
Carl Hetherington [Fri, 22 Apr 2022 08:23:20 +0000 (10:23 +0200)]
clang does not have -Wsuggest-override

2 years agoMissing override.
Carl Hetherington [Thu, 21 Apr 2022 22:01:04 +0000 (00:01 +0200)]
Missing override.

2 years agoDisable warnings around all wx includes.
Carl Hetherington [Thu, 21 Apr 2022 19:35:10 +0000 (21:35 +0200)]
Disable warnings around all wx includes.

2 years agoTidying.
Carl Hetherington [Thu, 21 Apr 2022 19:34:50 +0000 (21:34 +0200)]
Tidying.

2 years agoLookup the correct DCNC code to use for languages rather than just
Carl Hetherington [Sun, 17 Apr 2022 20:25:50 +0000 (22:25 +0200)]
Lookup the correct DCNC code to use for languages rather than just
using the language's subtag (#2235).

2 years agoUse std::vector in AudioBuffers (#2236).
Carl Hetherington [Tue, 19 Apr 2022 12:03:20 +0000 (14:03 +0200)]
Use std::vector in AudioBuffers (#2236).

2 years agoCleanup: improve some variable names.
Carl Hetherington [Tue, 19 Apr 2022 11:09:49 +0000 (13:09 +0200)]
Cleanup: improve some variable names.

2 years agoAdd ScopeGuard.
Carl Hetherington [Tue, 19 Apr 2022 10:56:10 +0000 (12:56 +0200)]
Add ScopeGuard.

2 years agoAdd button to use same fades for audio as video (#2230).
Carl Hetherington [Mon, 18 Apr 2022 20:40:22 +0000 (22:40 +0200)]
Add button to use same fades for audio as video (#2230).

2 years agoTidying.
Carl Hetherington [Mon, 18 Apr 2022 19:05:41 +0000 (21:05 +0200)]
Tidying.

2 years agoReplace encrypted content with black if we have no key (#2234).
Carl Hetherington [Sat, 16 Apr 2022 21:57:19 +0000 (23:57 +0200)]
Replace encrypted content with black if we have no key (#2234).

2 years agoC++11 tidying.
Carl Hetherington [Sat, 16 Apr 2022 21:56:06 +0000 (23:56 +0200)]
C++11 tidying.

2 years agoTidying.
Carl Hetherington [Wed, 20 Apr 2022 19:17:14 +0000 (21:17 +0200)]
Tidying.

2 years agoAdd more missing override labels.
Carl Hetherington [Sun, 17 Apr 2022 20:07:25 +0000 (22:07 +0200)]
Add more missing override labels.

2 years agoAdd deps for Ubuntu 22.04.
Carl Hetherington [Sun, 17 Apr 2022 19:09:15 +0000 (21:09 +0200)]
Add deps for Ubuntu 22.04.

2 years agoMissing override label.
Carl Hetherington [Sun, 17 Apr 2022 18:53:40 +0000 (20:53 +0200)]
Missing override label.

2 years agoRemove some commented-out code.
Carl Hetherington [Sun, 17 Apr 2022 17:08:07 +0000 (19:08 +0200)]
Remove some commented-out code.

2 years agoC++11 tidying.
Carl Hetherington [Sat, 9 Apr 2022 11:58:49 +0000 (13:58 +0200)]
C++11 tidying.

2 years agoWarn about missing override labels.
Carl Hetherington [Sat, 9 Apr 2022 11:58:41 +0000 (13:58 +0200)]
Warn about missing override labels.

2 years agoAdd some missing override labels.
Carl Hetherington [Sat, 9 Apr 2022 11:58:27 +0000 (13:58 +0200)]
Add some missing override labels.

2 years agoFix some comment typos.
Carl Hetherington [Fri, 8 Apr 2022 23:24:48 +0000 (01:24 +0200)]
Fix some comment typos.

2 years agoUpdate supporters list.
Carl Hetherington [Fri, 8 Apr 2022 17:58:50 +0000 (19:58 +0200)]
Update supporters list.

2 years agoMore missing override labels.
Carl Hetherington [Fri, 8 Apr 2022 15:04:39 +0000 (17:04 +0200)]
More missing override labels.

2 years agoMore missing override labels.
Carl Hetherington [Fri, 8 Apr 2022 12:29:01 +0000 (14:29 +0200)]
More missing override labels.

2 years agoAnother missing override label.
Carl Hetherington [Fri, 8 Apr 2022 12:08:27 +0000 (14:08 +0200)]
Another missing override label.

2 years agoAdd some missing override labels.
Carl Hetherington [Thu, 7 Apr 2022 23:03:50 +0000 (01:03 +0200)]
Add some missing override labels.

2 years agoGuess video range better when importing 2.14.x projects (#2227).
Carl Hetherington [Thu, 7 Apr 2022 22:43:28 +0000 (00:43 +0200)]
Guess video range better when importing 2.14.x projects (#2227).

2 years agoCleanup: tidying.
Carl Hetherington [Thu, 7 Apr 2022 21:51:19 +0000 (23:51 +0200)]
Cleanup: tidying.

2 years agoRemove erroneous comment.
Carl Hetherington [Thu, 7 Apr 2022 21:50:41 +0000 (23:50 +0200)]
Remove erroneous comment.

2 years agoC++11 and whitespace cleanups.
Carl Hetherington [Sat, 2 Apr 2022 22:04:31 +0000 (00:04 +0200)]
C++11 and whitespace cleanups.

2 years agoAdd button to send test emails in the mail server prefs (#2216).
Carl Hetherington [Fri, 1 Apr 2022 22:03:12 +0000 (00:03 +0200)]
Add button to send test emails in the mail server prefs (#2216).

2 years agoFix writing of planar audio to export buffers in some cases (#2223).
Carl Hetherington [Wed, 30 Mar 2022 20:59:05 +0000 (22:59 +0200)]
Fix writing of planar audio to export buffers in some cases (#2223).

Previously we did not take into account alignment padding that can
exist with FLTP samples; each channel's block of samples can have
a gap between.  This doesn't happen with the normal 1024 sample blocks;
only when flushing at the end, when we write shorter blocks.

Not doing this right meant that we were passing uninitialised memory
to aacenc which sometimes responded by returning an EINVAL due to one
of its internal calculations returning a NaN.

2 years agoTweak --export-filename help.
Carl Hetherington [Wed, 30 Mar 2022 17:56:19 +0000 (19:56 +0200)]
Tweak --export-filename help.

2 years agoRemove strange proportion values when adding content buttons.
Carl Hetherington [Sun, 27 Mar 2022 21:39:21 +0000 (23:39 +0200)]
Remove strange proportion values when adding content buttons.

These seemed to cause the buttons to appear in strange places in some
cases.

2 years agoSupporters update.
Carl Hetherington [Fri, 25 Mar 2022 18:28:40 +0000 (19:28 +0100)]
Supporters update.

2 years agoFix build error on mac.
Carl Hetherington [Mon, 21 Mar 2022 07:05:33 +0000 (08:05 +0100)]
Fix build error on mac.

2 years agoAdd check/uncheck all buttons to screens panel.
Carl Hetherington [Sun, 20 Mar 2022 23:54:18 +0000 (00:54 +0100)]
Add check/uncheck all buttons to screens panel.

2 years agoRemove unnecessary heading in email address list in cinema dialogue.
Carl Hetherington [Sun, 20 Mar 2022 20:47:09 +0000 (21:47 +0100)]
Remove unnecessary heading in email address list in cinema dialogue.

2 years agoAdd config option for default KDM type.
Carl Hetherington [Sat, 19 Mar 2022 21:34:00 +0000 (22:34 +0100)]
Add config option for default KDM type.

2 years agoMake a small class to choose KDM types.
Carl Hetherington [Sat, 19 Mar 2022 19:30:20 +0000 (20:30 +0100)]
Make a small class to choose KDM types.

2 years agoRemove KDM type that was added for testing.
Carl Hetherington [Sat, 19 Mar 2022 19:08:06 +0000 (20:08 +0100)]
Remove KDM type that was added for testing.

2 years agoAdd $CINEMA_SHORT_NAME variable in KDM emails.
Carl Hetherington [Sat, 19 Mar 2022 18:43:31 +0000 (19:43 +0100)]
Add $CINEMA_SHORT_NAME variable in KDM emails.

2 years agoCleanup: remove some duplicated code.
Carl Hetherington [Sat, 19 Mar 2022 18:34:22 +0000 (19:34 +0100)]
Cleanup: remove some duplicated code.

2 years agoWe can (and should) get the screens straight from _checked_screens now.
Carl Hetherington [Sat, 19 Mar 2022 18:23:07 +0000 (19:23 +0100)]
We can (and should) get the screens straight from _checked_screens now.

2 years agoNow we don't need _cinemas and _screens any more.
Carl Hetherington [Sat, 19 Mar 2022 18:21:19 +0000 (19:21 +0100)]
Now we don't need _cinemas and _screens any more.

2 years agoFix _selected_* to only store pointers to things.
Carl Hetherington [Sat, 19 Mar 2022 18:11:35 +0000 (19:11 +0100)]
Fix _selected_* to only store pointers to things.

The wxWidgets item IDs can easily become outdated (when a search
is done).

2 years agoSpeed things up by sorting before adding cinemas.
Carl Hetherington [Fri, 18 Mar 2022 22:52:58 +0000 (23:52 +0100)]
Speed things up by sorting before adding cinemas.

2 years agoPreserve checked status during search (#2212).
Carl Hetherington [Fri, 18 Mar 2022 21:50:12 +0000 (22:50 +0100)]
Preserve checked status during search (#2212).

2 years agoAdd an initialisation in the class.
Carl Hetherington [Fri, 18 Mar 2022 21:49:29 +0000 (22:49 +0100)]
Add an initialisation in the class.

2 years agoAlso keep maps the other way around.
Carl Hetherington [Fri, 18 Mar 2022 00:10:24 +0000 (01:10 +0100)]
Also keep maps the other way around.

2 years agoKeep maps of wxTreeListItem to Cinema/Screen.
Carl Hetherington [Thu, 17 Mar 2022 23:57:42 +0000 (00:57 +0100)]
Keep maps of wxTreeListItem to Cinema/Screen.

2 years agoFix writing KDMs with long filenames.
Carl Hetherington [Thu, 17 Mar 2022 20:45:46 +0000 (21:45 +0100)]
Fix writing KDMs with long filenames.

2 years agoUse the ICU library to sort cinemas rather than strcoll() (part of #2208).
Carl Hetherington [Wed, 16 Mar 2022 21:10:55 +0000 (22:10 +0100)]
Use the ICU library to sort cinemas rather than strcoll() (part of #2208).

strcoll() just doesn't really seem to work at all on Windows.

2 years agoEncode UTF-8 subjects and attachment names properly (#2207).
Carl Hetherington [Fri, 11 Mar 2022 22:35:43 +0000 (23:35 +0100)]
Encode UTF-8 subjects and attachment names properly (#2207).

2 years agoSlightly improve behaviour under low memory conditions.
Carl Hetherington [Fri, 11 Mar 2022 22:35:08 +0000 (23:35 +0100)]
Slightly improve behaviour under low memory conditions.

2 years agoUse a vector<pair<...>> to store screens and cinemas instead of a map.
Carl Hetherington [Fri, 11 Mar 2022 22:34:00 +0000 (23:34 +0100)]
Use a vector<pair<...>> to store screens and cinemas instead of a map.

In this way, ordering will be preserved (part of #2208).

2 years agoReplace class shim with a custom comparator.
Carl Hetherington [Sun, 13 Mar 2022 20:10:36 +0000 (21:10 +0100)]
Replace class shim with a custom comparator.

2 years agoFix weird placement of SetSortColumn() call causing strange assertion failure in...
Carl Hetherington [Sun, 13 Mar 2022 20:04:02 +0000 (21:04 +0100)]
Fix weird placement of SetSortColumn() call causing strange assertion failure in wxWidgets.

2 years agoCleanup: use some better variable names.
Carl Hetherington [Fri, 11 Mar 2022 21:41:36 +0000 (22:41 +0100)]
Cleanup: use some better variable names.

2 years agoMake the value used for 'f' in KDM names consistent (#1657).
Carl Hetherington [Thu, 10 Mar 2022 22:00:43 +0000 (23:00 +0100)]
Make the value used for 'f' in KDM names consistent (#1657).

Before it was mostly the film name, but this is confusing when a
single film contains multiple CPLs.

2 years agoCleanup: tidying.
Carl Hetherington [Sat, 5 Mar 2022 10:15:59 +0000 (11:15 +0100)]
Cleanup: tidying.

2 years agoFix tests for newly-saved write to/email checkboxes.
Carl Hetherington [Mon, 14 Mar 2022 21:16:52 +0000 (22:16 +0100)]
Fix tests for newly-saved write to/email checkboxes.

2 years agoFix incorrectly-timed emission of silence padding causing buffer fill (#2217).
Carl Hetherington [Mon, 14 Mar 2022 19:29:44 +0000 (20:29 +0100)]
Fix incorrectly-timed emission of silence padding causing buffer fill (#2217).

On initialisation or after seek we insert silence corresponding to
a positive delay in an audio stream.  Previously this inserted silence
was done at time 0, so that after a seek to time T the silent frames
would come out of the audio merger at time 0 and then the player would
fill the space up to time T with silence.  If T was far enough along
this would fill the audio buffers without there being any video.

2 years agoC++11 tidying.
Carl Hetherington [Mon, 14 Mar 2022 19:24:13 +0000 (20:24 +0100)]
C++11 tidying.

2 years agoCleanup: tidy some comments.
Carl Hetherington [Mon, 14 Mar 2022 19:23:47 +0000 (20:23 +0100)]
Cleanup: tidy some comments.

2 years agoRemember the state of the write to/email checkboxes in the KDM creator across runs...
Carl Hetherington [Sun, 13 Mar 2022 23:09:09 +0000 (00:09 +0100)]
Remember the state of the write to/email checkboxes in the KDM creator across runs (#2213).

2 years agoC++11 tidying.
Carl Hetherington [Sun, 13 Mar 2022 22:53:13 +0000 (23:53 +0100)]
C++11 tidying.

2 years agoTidying.
Carl Hetherington [Sun, 13 Mar 2022 22:52:49 +0000 (23:52 +0100)]
Tidying.

2 years agoFix sensitivity of custom scaled edit button.
Carl Hetherington [Sun, 13 Mar 2022 14:49:06 +0000 (15:49 +0100)]
Fix sensitivity of custom scaled edit button.

2 years agoAllow editing of a screen's cinema / adding a new screen when
Carl Hetherington [Fri, 11 Mar 2022 20:00:32 +0000 (21:00 +0100)]
Allow editing of a screen's cinema / adding a new screen when
a screen is selected (#2210).

2 years agoFix build with the macOS 10.8 version of wxWidgets.
Carl Hetherington [Thu, 10 Mar 2022 07:04:48 +0000 (08:04 +0100)]
Fix build with the macOS 10.8 version of wxWidgets.

2 years agoFix incorrect quoting in helper script.
Carl Hetherington [Wed, 2 Mar 2022 21:10:41 +0000 (22:10 +0100)]
Fix incorrect quoting in helper script.

2 years agoImprove ratings dialog to allow only valid values (#2199).
Carl Hetherington [Tue, 1 Mar 2022 21:41:56 +0000 (22:41 +0100)]
Improve ratings dialog to allow only valid values (#2199).

2 years agoAllow passing flags into TableDialog::add for labels.
Carl Hetherington [Tue, 1 Mar 2022 23:09:58 +0000 (00:09 +0100)]
Allow passing flags into TableDialog::add for labels.

2 years agoAdd search_ctrl_height()
Carl Hetherington [Tue, 1 Mar 2022 21:40:57 +0000 (22:40 +0100)]
Add search_ctrl_height()

2 years agoC++11 cleanup.
Carl Hetherington [Tue, 1 Mar 2022 21:40:47 +0000 (22:40 +0100)]
C++11 cleanup.

2 years agoDon't write a <ContentVersion> tag with an empty <LabelText> (#2191).
Carl Hetherington [Sun, 27 Feb 2022 22:45:46 +0000 (23:45 +0100)]
Don't write a <ContentVersion> tag with an empty <LabelText> (#2191).

I can't see the problem with this, but apparently Dolby
CineInspect complains about it.

We could fix this in libdcp but I think that would make more sense
if this were related to a definite standard violation, instead of
just some tinkering to hide a possibly-incorrect warning.

2 years agoUse some decimal places when reporting transcode speed in the log.
Carl Hetherington [Thu, 17 Feb 2022 20:46:41 +0000 (21:46 +0100)]
Use some decimal places when reporting transcode speed in the log.

2 years agoSupporters update.
Carl Hetherington [Wed, 9 Mar 2022 06:34:24 +0000 (07:34 +0100)]
Supporters update.