Rename "custom" reel type to "split by maximum reel size" (in the GUI).
[dcpomatic.git] / src / wx / dcp_panel.cc
index 4da8abe36ed1bdd3c33665ad06319c3a71c54be1..b789a1a74ec96da172442be064ab28b3b0c03f1d 100644 (file)
@@ -97,10 +97,6 @@ DCPPanel::DCPPanel(wxNotebook* n, shared_ptr<Film> film, FilmViewer& viewer)
                wxALIGN_CENTRE_HORIZONTAL | wxST_NO_AUTORESIZE | wxST_ELLIPSIZE_MIDDLE
                );
 
-       _enable_audio_language = new CheckBox(_panel, _("Audio language"));
-       _audio_language = new wxStaticText (_panel, wxID_ANY, wxT(""));
-       _edit_audio_language = new Button (_panel, _("Edit..."));
-
        _dcp_content_type_label = create_label (_panel, _("Content Type"), true);
        _dcp_content_type = new Choice(_panel);
 
@@ -139,23 +135,19 @@ DCPPanel::DCPPanel(wxNotebook* n, shared_ptr<Film> film, FilmViewer& viewer)
        _standard->Bind              (wxEVT_CHOICE,   boost::bind(&DCPPanel::standard_changed, this));
        _markers->Bind               (wxEVT_BUTTON,   boost::bind(&DCPPanel::markers_clicked, this));
        _metadata->Bind              (wxEVT_BUTTON,   boost::bind(&DCPPanel::metadata_clicked, this));
-       _enable_audio_language->bind(&DCPPanel::enable_audio_language_toggled, this);
-       _edit_audio_language->Bind   (wxEVT_BUTTON,   boost::bind(&DCPPanel::edit_audio_language_clicked, this));
-
        for (auto i: DCPContentType::all()) {
                _dcp_content_type->add(i->pretty_name());
        }
 
        _reel_type->add(_("Single reel"));
        _reel_type->add(_("Split by video content"));
-       /// TRANSLATORS: translate the word "Custom" here; do not include the "Reel|" prefix
-       _reel_type->add(S_("Reel|Custom"));
+       _reel_type->add(S_("Split by maximum reel size"));
        _reel_type->SetToolTip(_("How the DCP should be split into parts internally.  If in doubt, choose 'Single reel'"));
 
        _reel_length->SetRange (1, 64);
 
        add_standards();
-       _standard->SetToolTip(_("Which standard the DCP should use.  Interop is older and SMPTE is the modern standard.  If in doubt, choose 'SMPTE'"));
+       _standard->SetToolTip(_("The standard that the DCP should use.  Interop is older, and SMPTE is the newer (current) standard.  If in doubt, choose 'SMPTE'"));
 
        Config::instance()->Changed.connect (boost::bind(&DCPPanel::config_changed, this, _1));
 
@@ -241,15 +233,6 @@ DCPPanel::add_to_grid ()
        _grid->Add (_dcp_name, wxGBPosition(r, 0), wxGBSpan(1, 2), wxALIGN_CENTER_VERTICAL | wxEXPAND);
        ++r;
 
-       {
-               auto s = new wxBoxSizer (wxHORIZONTAL);
-               s->Add (_enable_audio_language, 0, wxALIGN_CENTER_VERTICAL | wxRIGHT, DCPOMATIC_SIZER_GAP);
-               s->Add (_audio_language, 1, wxALIGN_CENTER_VERTICAL | wxBOTTOM, DCPOMATIC_CHECKBOX_BOTTOM_PAD);
-               s->Add (_edit_audio_language, 0, wxALIGN_CENTER_VERTICAL | wxBOTTOM, DCPOMATIC_CHECKBOX_BOTTOM_PAD);
-               _grid->Add (s, wxGBPosition(r, 0), wxGBSpan(1, 2), wxEXPAND | wxALIGN_CENTER_VERTICAL);
-       }
-       ++r;
-
        add_label_to_sizer (_grid, _dcp_content_type_label, true, wxGBPosition(r, 0));
        _grid->Add (_dcp_content_type, wxGBPosition(r, 1));
        ++r;
@@ -390,19 +373,19 @@ DCPPanel::metadata_clicked ()
 
 
 void
-DCPPanel::film_changed (Film::Property p)
+DCPPanel::film_changed(FilmProperty p)
 {
        switch (p) {
-       case Film::Property::NONE:
+       case FilmProperty::NONE:
                break;
-       case Film::Property::CONTAINER:
+       case FilmProperty::CONTAINER:
                setup_container ();
                break;
-       case Film::Property::NAME:
+       case FilmProperty::NAME:
                checked_set (_name, _film->name());
                setup_dcp_name ();
                break;
-       case Film::Property::DCP_CONTENT_TYPE:
+       case FilmProperty::DCP_CONTENT_TYPE:
        {
                auto index = DCPContentType::as_index(_film->dcp_content_type());
                DCPOMATIC_ASSERT (index);
@@ -410,18 +393,18 @@ DCPPanel::film_changed (Film::Property p)
                setup_dcp_name ();
                break;
        }
-       case Film::Property::ENCRYPTED:
+       case FilmProperty::ENCRYPTED:
                checked_set (_encrypted, _film->encrypted ());
                break;
-       case Film::Property::RESOLUTION:
+       case FilmProperty::RESOLUTION:
                checked_set (_resolution, _film->resolution() == Resolution::TWO_K ? 0 : 1);
                setup_container ();
                setup_dcp_name ();
                break;
-       case Film::Property::J2K_BANDWIDTH:
+       case FilmProperty::J2K_BANDWIDTH:
                checked_set (_j2k_bandwidth, _film->j2k_bandwidth() / 1000000);
                break;
-       case Film::Property::USE_ISDCF_NAME:
+       case FilmProperty::USE_ISDCF_NAME:
        {
                checked_set (_use_isdcf_name, _film->use_isdcf_name());
                if (_film->use_isdcf_name()) {
@@ -437,7 +420,7 @@ DCPPanel::film_changed (Film::Property p)
                setup_dcp_name ();
                break;
        }
-       case Film::Property::VIDEO_FRAME_RATE:
+       case FilmProperty::VIDEO_FRAME_RATE:
        {
                bool done = false;
                for (unsigned int i = 0; i < _frame_rate_choice->GetCount(); ++i) {
@@ -458,7 +441,7 @@ DCPPanel::film_changed (Film::Property p)
                setup_dcp_name ();
                break;
        }
-       case Film::Property::AUDIO_CHANNELS:
+       case FilmProperty::AUDIO_CHANNELS:
                if (_film->audio_channels() < minimum_allowed_audio_channels()) {
                        _film->set_audio_channels (minimum_allowed_audio_channels());
                } else {
@@ -466,67 +449,72 @@ DCPPanel::film_changed (Film::Property p)
                        setup_dcp_name ();
                }
                break;
-       case Film::Property::THREE_D:
+       case FilmProperty::THREE_D:
                checked_set (_three_d, _film->three_d());
                setup_dcp_name ();
                break;
-       case Film::Property::REENCODE_J2K:
+       case FilmProperty::REENCODE_J2K:
                checked_set (_reencode_j2k, _film->reencode_j2k());
                break;
-       case Film::Property::INTEROP:
+       case FilmProperty::INTEROP:
                set_standard();
                setup_dcp_name ();
                _markers->Enable (!_film->interop());
                break;
-       case Film::Property::LIMIT_TO_SMPTE_BV20:
+       case FilmProperty::LIMIT_TO_SMPTE_BV20:
                set_standard();
                break;
-       case Film::Property::AUDIO_PROCESSOR:
+       case FilmProperty::AUDIO_PROCESSOR:
                if (_film->audio_processor()) {
                        checked_set (_audio_processor, _film->audio_processor()->id());
                } else {
                        checked_set (_audio_processor, 0);
                }
                setup_audio_channels_choice (_audio_channels, minimum_allowed_audio_channels());
-               film_changed (Film::Property::AUDIO_CHANNELS);
+               film_changed (FilmProperty::AUDIO_CHANNELS);
                break;
-       case Film::Property::REEL_TYPE:
+       case FilmProperty::REEL_TYPE:
                checked_set (_reel_type, static_cast<int>(_film->reel_type()));
                _reel_length->Enable (_film->reel_type() == ReelType::BY_LENGTH);
                break;
-       case Film::Property::REEL_LENGTH:
+       case FilmProperty::REEL_LENGTH:
                checked_set (_reel_length, _film->reel_length() / 1000000000LL);
                break;
-       case Film::Property::CONTENT:
+       case FilmProperty::CONTENT:
                setup_dcp_name ();
                setup_sensitivity ();
+               /* Maybe we now have ATMOS content which changes our minimum_allowed_audio_channels */
+               setup_audio_channels_choice(_audio_channels, minimum_allowed_audio_channels());
+               film_changed(FilmProperty::AUDIO_CHANNELS);
                break;
-       case Film::Property::AUDIO_LANGUAGE:
+       case FilmProperty::AUDIO_LANGUAGE:
        {
                auto al = _film->audio_language();
                checked_set (_enable_audio_language, static_cast<bool>(al));
                checked_set (_audio_language, al ? std_to_wx(al->to_string()) : wxT(""));
                setup_dcp_name ();
                setup_sensitivity ();
+               _audio_panel_sizer->Layout();
                break;
        }
-       case Film::Property::AUDIO_FRAME_RATE:
+       case FilmProperty::AUDIO_FRAME_RATE:
                if (_audio_sample_rate) {
                        checked_set (_audio_sample_rate, _film->audio_frame_rate() == 48000 ? 0 : 1);
                }
                break;
-       case Film::Property::CONTENT_VERSIONS:
-       case Film::Property::VERSION_NUMBER:
-       case Film::Property::RELEASE_TERRITORY:
-       case Film::Property::RATINGS:
-       case Film::Property::FACILITY:
-       case Film::Property::STUDIO:
-       case Film::Property::TEMP_VERSION:
-       case Film::Property::PRE_RELEASE:
-       case Film::Property::RED_BAND:
-       case Film::Property::TWO_D_VERSION_OF_THREE_D:
-       case Film::Property::CHAIN:
-       case Film::Property::LUMINANCE:
+       case FilmProperty::CONTENT_VERSIONS:
+       case FilmProperty::VERSION_NUMBER:
+       case FilmProperty::RELEASE_TERRITORY:
+       case FilmProperty::RATINGS:
+       case FilmProperty::FACILITY:
+       case FilmProperty::STUDIO:
+       case FilmProperty::TEMP_VERSION:
+       case FilmProperty::PRE_RELEASE:
+       case FilmProperty::RED_BAND:
+       case FilmProperty::TWO_D_VERSION_OF_THREE_D:
+       case FilmProperty::CHAIN:
+       case FilmProperty::LUMINANCE:
+       case FilmProperty::TERRITORY_TYPE:
                setup_dcp_name ();
                break;
        default:
@@ -543,6 +531,8 @@ DCPPanel::film_content_changed (int property)
            property == TextContentProperty::BURN ||
            property == TextContentProperty::LANGUAGE ||
            property == TextContentProperty::LANGUAGE_IS_ADDITIONAL ||
+           property == TextContentProperty::TYPE ||
+           property == TextContentProperty::DCP_TRACK ||
            property == VideoContentProperty::CUSTOM_RATIO ||
            property == VideoContentProperty::CUSTOM_SIZE ||
            property == VideoContentProperty::BURNT_SUBTITLE_LANGUAGE ||
@@ -588,11 +578,10 @@ DCPPanel::container_changed ()
                return;
        }
 
-       auto const n = _container->get();
-       if (n) {
+       if (auto const container = _container->get()) {
                auto ratios = Ratio::containers ();
-               DCPOMATIC_ASSERT(*n < int(ratios.size()));
-               _film->set_container(ratios[*n]);
+               DCPOMATIC_ASSERT(*container < int(ratios.size()));
+               _film->set_container(ratios[*container]);
        }
 }
 
@@ -605,9 +594,8 @@ DCPPanel::dcp_content_type_changed ()
                return;
        }
 
-       auto n = _dcp_content_type->get();
-       if (n) {
-               _film->set_dcp_content_type(DCPContentType::from_index(*n));
+       if (auto const type = _dcp_content_type->get()) {
+               _film->set_dcp_content_type(DCPContentType::from_index(*type));
        }
 }
 
@@ -633,26 +621,26 @@ DCPPanel::set_film (shared_ptr<Film> film)
        _standard->Clear();
        add_standards();
 
-       film_changed (Film::Property::NAME);
-       film_changed (Film::Property::USE_ISDCF_NAME);
-       film_changed (Film::Property::CONTENT);
-       film_changed (Film::Property::DCP_CONTENT_TYPE);
-       film_changed (Film::Property::CONTAINER);
-       film_changed (Film::Property::RESOLUTION);
-       film_changed (Film::Property::ENCRYPTED);
-       film_changed (Film::Property::J2K_BANDWIDTH);
-       film_changed (Film::Property::VIDEO_FRAME_RATE);
-       film_changed (Film::Property::AUDIO_CHANNELS);
-       film_changed (Film::Property::SEQUENCE);
-       film_changed (Film::Property::THREE_D);
-       film_changed (Film::Property::INTEROP);
-       film_changed (Film::Property::AUDIO_PROCESSOR);
-       film_changed (Film::Property::REEL_TYPE);
-       film_changed (Film::Property::REEL_LENGTH);
-       film_changed (Film::Property::REENCODE_J2K);
-       film_changed (Film::Property::AUDIO_LANGUAGE);
-       film_changed (Film::Property::AUDIO_FRAME_RATE);
-       film_changed (Film::Property::LIMIT_TO_SMPTE_BV20);
+       film_changed(FilmProperty::NAME);
+       film_changed(FilmProperty::USE_ISDCF_NAME);
+       film_changed(FilmProperty::CONTENT);
+       film_changed(FilmProperty::DCP_CONTENT_TYPE);
+       film_changed(FilmProperty::CONTAINER);
+       film_changed(FilmProperty::RESOLUTION);
+       film_changed(FilmProperty::ENCRYPTED);
+       film_changed(FilmProperty::J2K_BANDWIDTH);
+       film_changed(FilmProperty::VIDEO_FRAME_RATE);
+       film_changed(FilmProperty::AUDIO_CHANNELS);
+       film_changed(FilmProperty::SEQUENCE);
+       film_changed(FilmProperty::THREE_D);
+       film_changed(FilmProperty::INTEROP);
+       film_changed(FilmProperty::AUDIO_PROCESSOR);
+       film_changed(FilmProperty::REEL_TYPE);
+       film_changed(FilmProperty::REEL_LENGTH);
+       film_changed(FilmProperty::REENCODE_J2K);
+       film_changed(FilmProperty::AUDIO_LANGUAGE);
+       film_changed(FilmProperty::AUDIO_FRAME_RATE);
+       film_changed(FilmProperty::LIMIT_TO_SMPTE_BV20);
 
        set_general_sensitivity(static_cast<bool>(_film));
 }
@@ -683,7 +671,7 @@ DCPPanel::setup_sensitivity ()
        _metadata->Enable               (_generally_sensitive);
        _frame_rate_choice->Enable      (_generally_sensitive && _film && !_film->references_dcp_video() && !_film->contains_atmos_content());
        _frame_rate_spin->Enable        (_generally_sensitive && _film && !_film->references_dcp_video() && !_film->contains_atmos_content());
-       _audio_channels->Enable         (_generally_sensitive && _film && !_film->references_dcp_audio() && !_film->contains_atmos_content());
+       _audio_channels->Enable         (_generally_sensitive && _film && !_film->references_dcp_audio());
        _audio_processor->Enable        (_generally_sensitive && _film && !_film->references_dcp_audio());
        _j2k_bandwidth->Enable          (_generally_sensitive && _film && !_film->references_dcp_video());
        _container->Enable              (_generally_sensitive && _film && !_film->references_dcp_video());
@@ -723,6 +711,10 @@ DCPPanel::use_isdcf_name_toggled ()
 void
 DCPPanel::setup_dcp_name ()
 {
+       if (!_film) {
+               return;
+       }
+
        _dcp_name->SetLabel (std_to_wx(_film->dcp_name(true)));
        _dcp_name->SetToolTip (std_to_wx(_film->dcp_name(true)));
 }
@@ -771,14 +763,14 @@ DCPPanel::config_changed (Config::Property p)
                _audio_processor->Clear ();
                add_audio_processors ();
                if (_film) {
-                       film_changed (Film::Property::AUDIO_PROCESSOR);
+                       film_changed(FilmProperty::AUDIO_PROCESSOR);
                }
        } else if (p == Config::ALLOW_SMPTE_BV20) {
                _standard->Clear();
                add_standards();
                if (_film) {
-                       film_changed(Film::Property::INTEROP);
-                       film_changed(Film::Property::LIMIT_TO_SMPTE_BV20);
+                       film_changed(FilmProperty::INTEROP);
+                       film_changed(FilmProperty::LIMIT_TO_SMPTE_BV20);
                }
        } else if (p == Config::ISDCF_NAME_PART_LENGTH) {
                setup_dcp_name();
@@ -906,8 +898,13 @@ int
 DCPPanel::minimum_allowed_audio_channels () const
 {
        int min = 2;
-       if (_film && _film->audio_processor ()) {
-               min = _film->audio_processor()->out_channels ();
+       if (_film) {
+               if (_film->audio_processor()) {
+                       min = _film->audio_processor()->out_channels();
+               }
+               if (_film->contains_atmos_content()) {
+                       min = std::max(min, 14);
+               }
        }
 
        if (min % 2 == 1) {
@@ -940,6 +937,10 @@ DCPPanel::make_audio_panel ()
        _audio_processor = new Choice(panel);
        add_audio_processors ();
 
+       _enable_audio_language = new CheckBox(panel, _("Language"));
+       _audio_language = new wxStaticText(panel, wxID_ANY, wxT(""));
+       _edit_audio_language = new Button(panel, _("Edit..."));
+
        _show_audio = new Button (panel, _("Show graph of audio levels..."));
 
        _audio_channels->Bind (wxEVT_CHOICE, boost::bind (&DCPPanel::audio_channels_changed, this));
@@ -947,6 +948,10 @@ DCPPanel::make_audio_panel ()
                _audio_sample_rate->Bind (wxEVT_CHOICE, boost::bind(&DCPPanel::audio_sample_rate_changed, this));
        }
        _audio_processor->Bind (wxEVT_CHOICE, boost::bind (&DCPPanel::audio_processor_changed, this));
+
+       _enable_audio_language->bind(&DCPPanel::enable_audio_language_toggled, this);
+       _edit_audio_language->Bind(wxEVT_BUTTON, boost::bind(&DCPPanel::edit_audio_language_clicked, this));
+
        _show_audio->Bind (wxEVT_BUTTON, boost::bind (&DCPPanel::show_audio_clicked, this));
 
        if (_audio_sample_rate) {
@@ -979,6 +984,16 @@ DCPPanel::add_audio_panel_to_grid ()
        _audio_grid->Add (_audio_processor, wxGBPosition (r, 1));
        ++r;
 
+       {
+               auto s = new wxBoxSizer (wxHORIZONTAL);
+               s->Add(_enable_audio_language, 0, wxALIGN_CENTER_VERTICAL | wxRIGHT, DCPOMATIC_SIZER_GAP);
+               s->Add(_audio_language, 1, wxALIGN_CENTER_VERTICAL | wxBOTTOM, DCPOMATIC_CHECKBOX_BOTTOM_PAD);
+               s->Add(DCPOMATIC_SIZER_X_GAP, 0);
+               s->Add(_edit_audio_language, 0, wxALIGN_CENTER_VERTICAL | wxBOTTOM, DCPOMATIC_CHECKBOX_BOTTOM_PAD);
+               _audio_grid->Add(s, wxGBPosition(r, 0), wxGBSpan(1, 2), wxEXPAND | wxALIGN_CENTER_VERTICAL);
+       }
+       ++r;
+
        _audio_grid->Add (_show_audio, wxGBPosition (r, 0), wxGBSpan (1, 2));
        ++r;
 }