dcpomatic.git
10 months agoSet libswscale option which doesn't work. 2564-alpha
Carl Hetherington [Sun, 18 Jun 2023 22:51:53 +0000 (00:51 +0200)]
Set libswscale option which doesn't work.

10 months agoFix syntax error in cscript.
Carl Hetherington [Sat, 17 Jun 2023 21:58:01 +0000 (23:58 +0200)]
Fix syntax error in cscript.

10 months agoSlightly improve a crash when content goes away.
Carl Hetherington [Fri, 16 Jun 2023 20:57:06 +0000 (22:57 +0200)]
Slightly improve a crash when content goes away.

10 months agoFix crash when pressing Ctrl+T with no content (#2563).
Carl Hetherington [Fri, 16 Jun 2023 19:15:26 +0000 (21:15 +0200)]
Fix crash when pressing Ctrl+T with no content (#2563).

10 months agoDefend against divide by 0.
Carl Hetherington [Fri, 16 Jun 2023 19:14:42 +0000 (21:14 +0200)]
Defend against divide by 0.

10 months agoImprove some tooltips (#2560).
Carl Hetherington [Thu, 15 Jun 2023 22:51:38 +0000 (00:51 +0200)]
Improve some tooltips (#2560).

10 months agoCleanup: switch sense of if.
Carl Hetherington [Mon, 12 Jun 2023 22:03:52 +0000 (00:03 +0200)]
Cleanup: switch sense of if.

10 months agoFix failure to close verify progress window when finished.
Carl Hetherington [Mon, 12 Jun 2023 21:56:48 +0000 (23:56 +0200)]
Fix failure to close verify progress window when finished.

10 months agoCleanup: swap some wx_ptrs for locals.
Carl Hetherington [Mon, 12 Jun 2023 21:50:29 +0000 (23:50 +0200)]
Cleanup: swap some wx_ptrs for locals.

10 months agoCleanup: whitespace fix.
Carl Hetherington [Fri, 9 Jun 2023 21:22:45 +0000 (23:22 +0200)]
Cleanup: whitespace fix.

10 months agoDon't call DOMFrame::start_job from a non-UI thread.
Carl Hetherington [Fri, 9 Jun 2023 21:18:55 +0000 (23:18 +0200)]
Don't call DOMFrame::start_job from a non-UI thread.

10 months agoAllow building for Debian 12.
Carl Hetherington [Wed, 7 Jun 2023 07:48:58 +0000 (09:48 +0200)]
Allow building for Debian 12.

10 months agoFix player audio, almost totally broken by a stupid mistake v2.16.59
Carl Hetherington [Tue, 6 Jun 2023 17:36:24 +0000 (19:36 +0200)]
Fix player audio, almost totally broken by a stupid mistake
in 78b2c650a9249cb7165d269b4378391d31e68e8b

Following that commit 16 channel audio streams were being read
as 6-channel, with unsurprising consequences.

10 months agoSupporters update. v2.16.58
Carl Hetherington [Sun, 4 Jun 2023 22:52:01 +0000 (00:52 +0200)]
Supporters update.

10 months agoCope with bad DCPs better in the editor.
Carl Hetherington [Sat, 3 Jun 2023 19:18:36 +0000 (21:18 +0200)]
Cope with bad DCPs better in the editor.

10 months agoFix sizing of editor's reel dialog.
Carl Hetherington [Sat, 3 Jun 2023 19:14:46 +0000 (21:14 +0200)]
Fix sizing of editor's reel dialog.

10 months agoGive filler subtitle reels <LoadFont> nodes in SMPTE (#2547).
Carl Hetherington [Fri, 2 Jun 2023 20:21:52 +0000 (22:21 +0200)]
Give filler subtitle reels <LoadFont> nodes in SMPTE (#2547).

10 months agoFix missing subtitle language in CPL on auto-created empty subtitle assets (#2548).
Carl Hetherington [Wed, 31 May 2023 18:13:50 +0000 (20:13 +0200)]
Fix missing subtitle language in CPL on auto-created empty subtitle assets (#2548).

10 months agoTweak test timing hack script to accept stdin.
Carl Hetherington [Sat, 3 Jun 2023 20:23:58 +0000 (22:23 +0200)]
Tweak test timing hack script to accept stdin.

10 months agoMissing ConfigRestorer.
Carl Hetherington [Sat, 3 Jun 2023 18:54:42 +0000 (20:54 +0200)]
Missing ConfigRestorer.

10 months agoFix incorrect hint about having too many subtitle lines in some cases (#2546).
Carl Hetherington [Fri, 2 Jun 2023 21:38:16 +0000 (23:38 +0200)]
Fix incorrect hint about having too many subtitle lines in some cases (#2546).

10 months agoImprove a test failure message.
Carl Hetherington [Fri, 2 Jun 2023 21:37:58 +0000 (23:37 +0200)]
Improve a test failure message.

10 months agoBump lwext4 for slightly better debugging.
Carl Hetherington [Fri, 2 Jun 2023 14:45:55 +0000 (16:45 +0200)]
Bump lwext4 for slightly better debugging.

10 months agoBump required private git revision.
Carl Hetherington [Thu, 1 Jun 2023 21:45:39 +0000 (23:45 +0200)]
Bump required private git revision.

10 months agoAdd dcpomatic2_{map,cli} to the main AppImage (#2549).
Carl Hetherington [Wed, 31 May 2023 19:13:34 +0000 (21:13 +0200)]
Add dcpomatic2_{map,cli} to the main AppImage (#2549).

10 months agoDon't show warning when only removing an empty DKDM folder (#2541).
Carl Hetherington [Tue, 30 May 2023 18:31:53 +0000 (20:31 +0200)]
Don't show warning when only removing an empty DKDM folder (#2541).

10 months agoDon't add DKDMs twice (#2545).
Carl Hetherington [Tue, 30 May 2023 16:11:55 +0000 (18:11 +0200)]
Don't add DKDMs twice (#2545).

10 months agoFix errors when mapping DCPs referring to the same asset multiple times (#2542).
Carl Hetherington [Tue, 30 May 2023 15:21:24 +0000 (17:21 +0200)]
Fix errors when mapping DCPs referring to the same asset multiple times (#2542).

10 months agoClarify some test failure messages.
Carl Hetherington [Tue, 30 May 2023 15:20:32 +0000 (17:20 +0200)]
Clarify some test failure messages.

10 months agoAdd a test with hard-linking.
Carl Hetherington [Tue, 30 May 2023 12:42:53 +0000 (14:42 +0200)]
Add a test with hard-linking.

10 months agoMove test into its own method.
Carl Hetherington [Tue, 30 May 2023 12:31:24 +0000 (14:31 +0200)]
Move test into its own method.

10 months agoAdd --config option to map (#2543).
Carl Hetherington [Tue, 30 May 2023 10:23:00 +0000 (12:23 +0200)]
Add --config option to map (#2543).

10 months agoFix disappearing DKDM folders when dragging a folder into its own child (#2540)
Carl Hetherington [Mon, 29 May 2023 23:29:28 +0000 (01:29 +0200)]
Fix disappearing DKDM folders when dragging a folder into its own child (#2540)

10 months agoSupporters update. v2.16.57
Carl Hetherington [Mon, 29 May 2023 20:54:50 +0000 (22:54 +0200)]
Supporters update.

10 months agoFocus the "make DCP/OK" button in the hints dialog (#2539).
Carl Hetherington [Mon, 29 May 2023 20:47:48 +0000 (22:47 +0200)]
Focus the "make DCP/OK" button in the hints dialog (#2539).

11 months agoDon't write Markers to interop CPLs (#2537).
Carl Hetherington [Sun, 28 May 2023 18:59:38 +0000 (20:59 +0200)]
Don't write Markers to interop CPLs (#2537).

11 months agoMissing bump of libdcp version.
Carl Hetherington [Mon, 29 May 2023 07:32:03 +0000 (09:32 +0200)]
Missing bump of libdcp version.

11 months agoReport the number of active channels in DCPs, not the number in the MXF.
Carl Hetherington [Sun, 28 May 2023 21:35:25 +0000 (23:35 +0200)]
Report the number of active channels in DCPs, not the number in the MXF.

11 months agoBump libdcp for fix to crash with interop subtitles (#2536).
Carl Hetherington [Sat, 27 May 2023 21:44:52 +0000 (23:44 +0200)]
Bump libdcp for fix to crash with interop subtitles (#2536).

11 months agoSupporters update.
Carl Hetherington [Sun, 28 May 2023 16:10:17 +0000 (18:10 +0200)]
Supporters update.

11 months agoCleanup: whitespace.
Carl Hetherington [Thu, 18 May 2023 20:23:05 +0000 (22:23 +0200)]
Cleanup: whitespace.

11 months agoCleanup: replace some list with vector.
Carl Hetherington [Thu, 18 May 2023 20:21:33 +0000 (22:21 +0200)]
Cleanup: replace some list with vector.

11 months agoCleanup: using sorting.
Carl Hetherington [Thu, 18 May 2023 20:20:44 +0000 (22:20 +0200)]
Cleanup: using sorting.

11 months agoCleanup: remove unused include.
Carl Hetherington [Thu, 18 May 2023 20:20:34 +0000 (22:20 +0200)]
Cleanup: remove unused include.

11 months agoUpdated cs_CZ translation from Tomáš Begeni.
Carl Hetherington [Mon, 15 May 2023 09:23:07 +0000 (11:23 +0200)]
Updated cs_CZ translation from Tomáš Begeni.

11 months agoPatrons update.
Carl Hetherington [Sun, 14 May 2023 22:13:47 +0000 (00:13 +0200)]
Patrons update.

11 months agoMissing dcpomatic2_map on RPM builds. v2.16.56
Carl Hetherington [Sun, 14 May 2023 10:35:11 +0000 (12:35 +0200)]
Missing dcpomatic2_map on RPM builds.

11 months agoRe-order binary names.
Carl Hetherington [Sat, 13 May 2023 20:39:53 +0000 (22:39 +0200)]
Re-order binary names.

I've no idea why this works (to fix weird errors from the Apple signing
stuff) but it does...

11 months agoCleanup: use a namespace.
Carl Hetherington [Sat, 13 May 2023 20:07:47 +0000 (22:07 +0200)]
Cleanup: use a namespace.

11 months agoCleanup: remove unnecessary explicit.
Carl Hetherington [Sat, 13 May 2023 20:02:53 +0000 (22:02 +0200)]
Cleanup: remove unnecessary explicit.

11 months agoMissing relink of dcpomatic2_map.
Carl Hetherington [Sat, 13 May 2023 19:09:49 +0000 (21:09 +0200)]
Missing relink of dcpomatic2_map.

11 months agoFix missing signing of dcpomatic2_map.
Carl Hetherington [Sat, 13 May 2023 17:14:20 +0000 (19:14 +0200)]
Fix missing signing of dcpomatic2_map.

11 months agoSupporters update.
Carl Hetherington [Sat, 13 May 2023 15:36:16 +0000 (17:36 +0200)]
Supporters update.

11 months agoAdd dcpomatic2_map tool (#2445).
Carl Hetherington [Fri, 17 Feb 2023 23:15:30 +0000 (00:15 +0100)]
Add dcpomatic2_map tool (#2445).

11 months agoCleanup: using ordering.
Carl Hetherington [Fri, 14 Apr 2023 14:41:38 +0000 (16:41 +0200)]
Cleanup: using ordering.

11 months agoFix typos in errors.
Carl Hetherington [Tue, 11 Apr 2023 21:04:24 +0000 (23:04 +0200)]
Fix typos in errors.

11 months agoFix typo in variable name.
Carl Hetherington [Tue, 11 Apr 2023 21:04:07 +0000 (23:04 +0200)]
Fix typo in variable name.

11 months agoRemove unused define.
Carl Hetherington [Tue, 11 Apr 2023 21:03:40 +0000 (23:03 +0200)]
Remove unused define.

11 months agoFix some typos in comments.
Carl Hetherington [Tue, 11 Apr 2023 21:03:36 +0000 (23:03 +0200)]
Fix some typos in comments.

11 months agoAdd verify_dcp().
Carl Hetherington [Fri, 17 Feb 2023 23:15:10 +0000 (00:15 +0100)]
Add verify_dcp().

11 months agoOnly add fonts to assets when they are required.
Carl Hetherington [Fri, 12 May 2023 00:19:36 +0000 (02:19 +0200)]
Only add fonts to assets when they are required.

11 months agoCleanup: whitespace fix.
Carl Hetherington [Thu, 11 May 2023 22:46:28 +0000 (00:46 +0200)]
Cleanup: whitespace fix.

11 months agoHandle fonts for ccaps coming from DCP content (#2525).
Carl Hetherington [Thu, 11 May 2023 11:50:57 +0000 (13:50 +0200)]
Handle fonts for ccaps coming from DCP content (#2525).

Not dealing with them calls all sort of chaos as described in the
bug report.

11 months agoadd_fonts_from_examiner() can be called multiple times with the same font
Carl Hetherington [Thu, 11 May 2023 11:48:58 +0000 (13:48 +0200)]
add_fonts_from_examiner() can be called multiple times with the same font
in the case of closed captions with multiple tracks.  Don't reuse the
same font objects in this case, otherwise we will start with something
like font, disambiguate it to 0_font, then disambiguate _that_ to
0_0_font.

11 months agoFix _text_count for ccaps when there are multiple reels.
Carl Hetherington [Thu, 11 May 2023 11:47:35 +0000 (13:47 +0200)]
Fix _text_count for ccaps when there are multiple reels.

Previously we would get a _text_count of 1 for open subs, no matter
how many reels there were, but for ccaps the _text_count would
increase with the number of tracks _and_ the number of reels.

11 months agoFix comment.
Carl Hetherington [Thu, 11 May 2023 11:45:02 +0000 (13:45 +0200)]
Fix comment.

11 months agoAllow copy-construction of Font.
Carl Hetherington [Thu, 11 May 2023 11:44:57 +0000 (13:44 +0200)]
Allow copy-construction of Font.

11 months agoCleanup: include/using sorting.
Carl Hetherington [Thu, 11 May 2023 00:46:22 +0000 (02:46 +0200)]
Cleanup: include/using sorting.

11 months agoRemove incorrect silencing (#2526).
Carl Hetherington [Thu, 11 May 2023 01:24:57 +0000 (03:24 +0200)]
Remove incorrect silencing (#2526).

On switching to the new FFmpeg send/receive API in
e29ce33a36c2e20444d57196defc86d5072bce81
the channels variable in deinterleave_audio() was switched from
stream channels to frame channels.

I'm not sure if this is right, but it does mean that audio has
`channels` channels, so calling make_silent() up to the stream
channel count is clearly wrong if the stream has more channels
than the frame.

11 months agoFix uninitialised variable caught by the macOS compiler.
Carl Hetherington [Wed, 10 May 2023 14:36:44 +0000 (16:36 +0200)]
Fix uninitialised variable caught by the macOS compiler.

11 months agoAdd some assertions.
Carl Hetherington [Tue, 9 May 2023 18:22:07 +0000 (20:22 +0200)]
Add some assertions.

11 months agoDon't edit start trim unless it's necessary.
Carl Hetherington [Mon, 8 May 2023 23:41:31 +0000 (01:41 +0200)]
Don't edit start trim unless it's necessary.

11 months agoAllow signals to be blocked and resumed, and so make sure that a set
Carl Hetherington [Mon, 8 May 2023 23:33:45 +0000 (01:33 +0200)]
Allow signals to be blocked and resumed, and so make sure that a set
of content changes taken from an examiner are handled at the same
time.

Should fix DoM #2523.

11 months agoCleanup: more variable renames.
Carl Hetherington [Sat, 6 May 2023 22:01:38 +0000 (00:01 +0200)]
Cleanup: more variable renames.

11 months agoCleanup: rename variable.
Carl Hetherington [Sat, 6 May 2023 21:50:06 +0000 (23:50 +0200)]
Cleanup: rename variable.

11 months agoFix old C++ syntax.
Carl Hetherington [Mon, 8 May 2023 21:33:49 +0000 (23:33 +0200)]
Fix old C++ syntax.

11 months agoFix typo in comment.
Carl Hetherington [Mon, 8 May 2023 21:33:39 +0000 (23:33 +0200)]
Fix typo in comment.

12 months agoCope with WEBVTT files named with .srt extensions.
Carl Hetherington [Thu, 27 Apr 2023 22:13:20 +0000 (00:13 +0200)]
Cope with WEBVTT files named with .srt extensions.

12 months agoDon't use wx_ptr for the splash screen.
Carl Hetherington [Tue, 25 Apr 2023 09:03:54 +0000 (11:03 +0200)]
Don't use wx_ptr for the splash screen.

Using wx_ptr in the wxApp object seems bad because in ~App wxWidgets
deletes all top-level windows in `DeleteAllTLWs` so if ~wx_ptr then
tries to destroy them we get a use-after-free.

12 months agoCleanup: remove some unnecessary includes.
Carl Hetherington [Tue, 25 Apr 2023 09:03:42 +0000 (11:03 +0200)]
Cleanup: remove some unnecessary includes.

12 months agoFix length()/bytes() mismatch on XML string.
Carl Hetherington [Sun, 23 Apr 2023 20:45:35 +0000 (22:45 +0200)]
Fix length()/bytes() mismatch on XML string.

12 months agoAdd some missing replacements.
Carl Hetherington [Sat, 22 Apr 2023 19:20:16 +0000 (21:20 +0200)]
Add some missing replacements.

12 months agoAdd some more bandwidths to a test.
Carl Hetherington [Sat, 22 Apr 2023 19:20:12 +0000 (21:20 +0200)]
Add some more bandwidths to a test.

12 months agoAdd some missing Ubuntu 23.04 dependencies. v2.16.55
Carl Hetherington [Fri, 21 Apr 2023 22:53:44 +0000 (00:53 +0200)]
Add some missing Ubuntu 23.04 dependencies.

12 months agoSupporters update. v2.16.54
Carl Hetherington [Fri, 21 Apr 2023 08:51:52 +0000 (10:51 +0200)]
Supporters update.

12 months agoUpdate wscript (missed in last commit).
Carl Hetherington [Fri, 21 Apr 2023 08:51:31 +0000 (10:51 +0200)]
Update wscript (missed in last commit).

12 months agoBump libdcp to 1.8.67.
Carl Hetherington [Thu, 20 Apr 2023 10:14:12 +0000 (12:14 +0200)]
Bump libdcp to 1.8.67.

12 months agoFix lack of email sending if there are no cinema addresses (only extra ones) (#2514).
Carl Hetherington [Thu, 20 Apr 2023 19:49:57 +0000 (21:49 +0200)]
Fix lack of email sending if there are no cinema addresses (only extra ones) (#2514).

12 months agoIn 1c73379ed8483dcf71c5ccfc459c2c22516a9aef I changed
Carl Hetherington [Wed, 19 Apr 2023 21:57:03 +0000 (23:57 +0200)]
In 1c73379ed8483dcf71c5ccfc459c2c22516a9aef I changed
FontConfig::_available_fonts to use the font ID as a key, but that's
totally wrong because the same Font object with the same ID can have
its font filename/data changed, and in that case we don't want to
use the cached font.

Here we use the actual TTF/OTF font data as the key.  We could have
just hashed the data (whether it comes from a disk file or is held
in memory) but this is slower in the case where we have the filename,
as then the file must be loaded from disk for each comparison.

This fixes #2518.

12 months agoWrap path/data in a struct.
Carl Hetherington [Wed, 19 Apr 2023 21:53:58 +0000 (23:53 +0200)]
Wrap path/data in a struct.

12 months agoAdd a comment.
Carl Hetherington [Wed, 19 Apr 2023 21:53:14 +0000 (23:53 +0200)]
Add a comment.

12 months agoFix crash if saving files during save/cancel/close (#2517).
Carl Hetherington [Tue, 18 Apr 2023 19:04:27 +0000 (21:04 +0200)]
Fix crash if saving files during save/cancel/close (#2517).

12 months agoCleanup: longer variable name.
Carl Hetherington [Tue, 18 Apr 2023 10:53:16 +0000 (12:53 +0200)]
Cleanup: longer variable name.

12 months agoSlight improvement to error when failing to save a metadata file.
Carl Hetherington [Tue, 18 Apr 2023 09:28:19 +0000 (11:28 +0200)]
Slight improvement to error when failing to save a metadata file.

12 months agoUpdate dcpomatic-test-private for some v2.17.x changes that don't affect main.
Carl Hetherington [Fri, 14 Apr 2023 21:16:28 +0000 (23:16 +0200)]
Update dcpomatic-test-private for some v2.17.x changes that don't affect main.

12 months agoDefault to 14fL luminance in the GUI.
Carl Hetherington [Wed, 12 Apr 2023 10:00:47 +0000 (12:00 +0200)]
Default to 14fL luminance in the GUI.

12 months agoGive an error if a non-number is passed to dcpomatic2_create -s (#2488).
Carl Hetherington [Mon, 10 Apr 2023 22:54:13 +0000 (00:54 +0200)]
Give an error if a non-number is passed to dcpomatic2_create -s (#2488).

12 months agoSupporters update. v2.16.53
Carl Hetherington [Tue, 11 Apr 2023 08:01:57 +0000 (10:01 +0200)]
Supporters update.

12 months agoBump ffcmp to fix ffmpeg dependency.
Carl Hetherington [Mon, 10 Apr 2023 20:47:30 +0000 (22:47 +0200)]
Bump ffcmp to fix ffmpeg dependency.

12 months agoFix subtitle font handling with in-memory fonts from SMPTE (#2509). v2.16.52
Carl Hetherington [Fri, 7 Apr 2023 23:04:37 +0000 (01:04 +0200)]
Fix subtitle font handling with in-memory fonts from SMPTE (#2509).

Previously we would fail to make a font available if it came from
a SMPTE MXF.  In that case we have a memory buffer containing the
TTF/OTF file but no file; here we add a hack/workaround so that
in-memory font files can be used by FontConfig.