dcpomatic.git
8 months agoWrite 8 or 16 audio channels to SMPTE DCP MXFs, as appropriate (#2443). channels-again2
Carl Hetherington [Tue, 25 Jul 2023 09:04:30 +0000 (11:04 +0200)]
Write 8 or 16 audio channels to SMPTE DCP MXFs, as appropriate (#2443).

8 months agoAdd audio_channels_to_write_to_mxf().
Carl Hetherington [Tue, 25 Jul 2023 11:11:14 +0000 (13:11 +0200)]
Add audio_channels_to_write_to_mxf().

9 months agoCheck channel count when comparing audio MXFs.
Carl Hetherington [Sat, 29 Jul 2023 00:27:02 +0000 (02:27 +0200)]
Check channel count when comparing audio MXFs.

9 months agoDon't check sound assets in some tests.
Carl Hetherington [Sat, 29 Jul 2023 00:26:33 +0000 (02:26 +0200)]
Don't check sound assets in some tests.

When fiddling with MXF channel counts it makes a lot of tests fail
that probably don't need to.

9 months agoBump libdcp to one with some cleanups / header re-arrangement.
Carl Hetherington [Tue, 25 Jul 2023 20:49:23 +0000 (22:49 +0200)]
Bump libdcp to one with some cleanups / header re-arrangement.

9 months agoAdd stubs for Georgian (ka_KA) language support.
Carl Hetherington [Sun, 23 Jul 2023 22:01:22 +0000 (00:01 +0200)]
Add stubs for Georgian (ka_KA) language support.

9 months agoFix copy-paste error.
Carl Hetherington [Sun, 23 Jul 2023 22:01:04 +0000 (00:01 +0200)]
Fix copy-paste error.

9 months agoCleanup: lengthen some short variable names.
Carl Hetherington [Sat, 22 Jul 2023 15:32:45 +0000 (17:32 +0200)]
Cleanup: lengthen some short variable names.

9 months agoSupporters update. v2.16.60
Carl Hetherington [Wed, 19 Jul 2023 08:05:50 +0000 (10:05 +0200)]
Supporters update.

9 months agoUpdated zh_CN translation from Akivili Collindort.
Carl Hetherington [Wed, 19 Jul 2023 08:04:56 +0000 (10:04 +0200)]
Updated zh_CN translation from Akivili Collindort.

9 months agoThis check used to be for asset channel count mismatches, then it was
Carl Hetherington [Mon, 17 Jul 2023 21:14:38 +0000 (23:14 +0200)]
This check used to be for asset channel count mismatches, then it was
changed to the active count, but I don't think it should be an error
to have different active counts between assets of a single DCP.

9 months agoCleanup: member variable name standard.
Carl Hetherington [Fri, 7 Jul 2023 11:58:28 +0000 (13:58 +0200)]
Cleanup: member variable name standard.

9 months agoFix crash if an exception is thrown before the splash screen is created.
Carl Hetherington [Sun, 2 Jul 2023 21:51:55 +0000 (23:51 +0200)]
Fix crash if an exception is thrown before the splash screen is created.

9 months agoDon't insert incorrect <Effect> nodes into metadata (#2581).
Carl Hetherington [Sun, 2 Jul 2023 20:03:28 +0000 (22:03 +0200)]
Don't insert incorrect <Effect> nodes into metadata (#2581).

Previously we would add assume Effect=none (i.e. force all subtitles
to have no effect) if neither of the legacy tags Border or Shadow
were present in the metadata.  In this case we should just leave
Effect as unset.

9 months agoAdd another test.
Carl Hetherington [Fri, 30 Jun 2023 22:05:20 +0000 (00:05 +0200)]
Add another test.

9 months agoDon't write MainSoundConfiguration with 71 when we only have HI/VI (#2580).
Carl Hetherington [Fri, 30 Jun 2023 21:54:42 +0000 (23:54 +0200)]
Don't write MainSoundConfiguration with 71 when we only have HI/VI (#2580).

9 months agoAdd channel_is_mapped().
Carl Hetherington [Fri, 30 Jun 2023 21:53:57 +0000 (23:53 +0200)]
Add channel_is_mapped().

9 months agoClean up after some more tests.
Carl Hetherington [Thu, 29 Jun 2023 23:59:18 +0000 (01:59 +0200)]
Clean up after some more tests.

10 months agoDisable asset hash checks that the libdcp bump fixes.
Carl Hetherington [Wed, 28 Jun 2023 21:02:49 +0000 (23:02 +0200)]
Disable asset hash checks that the libdcp bump fixes.

10 months agoMissing i18n markup.
Carl Hetherington [Mon, 26 Jun 2023 23:33:45 +0000 (01:33 +0200)]
Missing i18n markup.

10 months agoKeep "correct" hashes in dcpomatic2_map rather than recalculating them (#2555).
Carl Hetherington [Tue, 20 Jun 2023 20:07:50 +0000 (22:07 +0200)]
Keep "correct" hashes in dcpomatic2_map rather than recalculating them (#2555).

10 months agoBump libdcp for changes to how hashes are handled.
Carl Hetherington [Mon, 26 Jun 2023 22:16:01 +0000 (00:16 +0200)]
Bump libdcp for changes to how hashes are handled.

10 months agoWe no longer need to these bundle IDs.
Carl Hetherington [Sun, 25 Jun 2023 21:37:36 +0000 (23:37 +0200)]
We no longer need to these bundle IDs.

They were being passed to altool but when switching to notarytool
it seems that these IDs were never used and can now be omitted.

10 months agoTolerate problems when reading the contents of DCPs.
Carl Hetherington [Sun, 25 Jun 2023 20:34:47 +0000 (22:34 +0200)]
Tolerate problems when reading the contents of DCPs.

This avoids errors in cases like unreadable lost+found directories
appearing inside a DCP.

10 months agoFix config test reference after ISDCF name config option.
Carl Hetherington [Sat, 24 Jun 2023 07:58:22 +0000 (09:58 +0200)]
Fix config test reference after ISDCF name config option.

10 months agoAdd config option to allow long ISDCF name parts.
Carl Hetherington [Fri, 23 Jun 2023 22:54:28 +0000 (00:54 +0200)]
Add config option to allow long ISDCF name parts.

10 months agoAvoid virtual call to set_film() in constructor (#2571).
Carl Hetherington [Thu, 22 Jun 2023 15:45:17 +0000 (17:45 +0200)]
Avoid virtual call to set_film() in constructor (#2571).

10 months agoRemove unnecessary config_changed() which will only result in setup_sensitivity(...
Carl Hetherington [Thu, 22 Jun 2023 15:41:27 +0000 (17:41 +0200)]
Remove unnecessary config_changed() which will only result in setup_sensitivity() being called again.

10 months agoNo need to call setup_sensitivity() here as set_film() already does it.
Carl Hetherington [Thu, 22 Jun 2023 15:35:07 +0000 (17:35 +0200)]
No need to call setup_sensitivity() here as set_film() already does it.

10 months agoset_film() no longer needs to be virtual.
Carl Hetherington [Thu, 22 Jun 2023 15:23:47 +0000 (17:23 +0200)]
set_film() no longer needs to be virtual.

10 months agoControls::set_film() calls setup_sensitivity() so there's no need for PlaylistControl...
Carl Hetherington [Thu, 22 Jun 2023 15:21:30 +0000 (17:21 +0200)]
Controls::set_film() calls setup_sensitivity() so there's no need for PlaylistControls::set_film() also to do it.

10 months agoGive a better error when map doesn't find an asset.
Carl Hetherington [Tue, 20 Jun 2023 20:07:39 +0000 (22:07 +0200)]
Give a better error when map doesn't find an asset.

10 months agoAdd new(?) filename for some IMB certificates.
Carl Hetherington [Tue, 20 Jun 2023 13:03:01 +0000 (15:03 +0200)]
Add new(?) filename for some IMB certificates.

10 months agoCleanup: use a struct/pair rather than two separate lists.
Carl Hetherington [Tue, 20 Jun 2023 12:52:05 +0000 (14:52 +0200)]
Cleanup: use a struct/pair rather than two separate lists.

10 months agoFix syntax error in cscript.
Carl Hetherington [Sat, 17 Jun 2023 21:58:01 +0000 (23:58 +0200)]
Fix syntax error in cscript.

10 months agoSlightly improve a crash when content goes away.
Carl Hetherington [Fri, 16 Jun 2023 20:57:06 +0000 (22:57 +0200)]
Slightly improve a crash when content goes away.

10 months agoFix crash when pressing Ctrl+T with no content (#2563).
Carl Hetherington [Fri, 16 Jun 2023 19:15:26 +0000 (21:15 +0200)]
Fix crash when pressing Ctrl+T with no content (#2563).

10 months agoDefend against divide by 0.
Carl Hetherington [Fri, 16 Jun 2023 19:14:42 +0000 (21:14 +0200)]
Defend against divide by 0.

10 months agoImprove some tooltips (#2560).
Carl Hetherington [Thu, 15 Jun 2023 22:51:38 +0000 (00:51 +0200)]
Improve some tooltips (#2560).

10 months agoCleanup: switch sense of if.
Carl Hetherington [Mon, 12 Jun 2023 22:03:52 +0000 (00:03 +0200)]
Cleanup: switch sense of if.

10 months agoFix failure to close verify progress window when finished.
Carl Hetherington [Mon, 12 Jun 2023 21:56:48 +0000 (23:56 +0200)]
Fix failure to close verify progress window when finished.

10 months agoCleanup: swap some wx_ptrs for locals.
Carl Hetherington [Mon, 12 Jun 2023 21:50:29 +0000 (23:50 +0200)]
Cleanup: swap some wx_ptrs for locals.

10 months agoCleanup: whitespace fix.
Carl Hetherington [Fri, 9 Jun 2023 21:22:45 +0000 (23:22 +0200)]
Cleanup: whitespace fix.

10 months agoDon't call DOMFrame::start_job from a non-UI thread.
Carl Hetherington [Fri, 9 Jun 2023 21:18:55 +0000 (23:18 +0200)]
Don't call DOMFrame::start_job from a non-UI thread.

10 months agoAllow building for Debian 12.
Carl Hetherington [Wed, 7 Jun 2023 07:48:58 +0000 (09:48 +0200)]
Allow building for Debian 12.

10 months agoFix player audio, almost totally broken by a stupid mistake v2.16.59
Carl Hetherington [Tue, 6 Jun 2023 17:36:24 +0000 (19:36 +0200)]
Fix player audio, almost totally broken by a stupid mistake
in 78b2c650a9249cb7165d269b4378391d31e68e8b

Following that commit 16 channel audio streams were being read
as 6-channel, with unsurprising consequences.

10 months agoSupporters update. v2.16.58
Carl Hetherington [Sun, 4 Jun 2023 22:52:01 +0000 (00:52 +0200)]
Supporters update.

10 months agoCope with bad DCPs better in the editor.
Carl Hetherington [Sat, 3 Jun 2023 19:18:36 +0000 (21:18 +0200)]
Cope with bad DCPs better in the editor.

10 months agoFix sizing of editor's reel dialog.
Carl Hetherington [Sat, 3 Jun 2023 19:14:46 +0000 (21:14 +0200)]
Fix sizing of editor's reel dialog.

10 months agoGive filler subtitle reels <LoadFont> nodes in SMPTE (#2547).
Carl Hetherington [Fri, 2 Jun 2023 20:21:52 +0000 (22:21 +0200)]
Give filler subtitle reels <LoadFont> nodes in SMPTE (#2547).

10 months agoFix missing subtitle language in CPL on auto-created empty subtitle assets (#2548).
Carl Hetherington [Wed, 31 May 2023 18:13:50 +0000 (20:13 +0200)]
Fix missing subtitle language in CPL on auto-created empty subtitle assets (#2548).

10 months agoTweak test timing hack script to accept stdin.
Carl Hetherington [Sat, 3 Jun 2023 20:23:58 +0000 (22:23 +0200)]
Tweak test timing hack script to accept stdin.

10 months agoMissing ConfigRestorer.
Carl Hetherington [Sat, 3 Jun 2023 18:54:42 +0000 (20:54 +0200)]
Missing ConfigRestorer.

10 months agoFix incorrect hint about having too many subtitle lines in some cases (#2546).
Carl Hetherington [Fri, 2 Jun 2023 21:38:16 +0000 (23:38 +0200)]
Fix incorrect hint about having too many subtitle lines in some cases (#2546).

10 months agoImprove a test failure message.
Carl Hetherington [Fri, 2 Jun 2023 21:37:58 +0000 (23:37 +0200)]
Improve a test failure message.

10 months agoBump lwext4 for slightly better debugging.
Carl Hetherington [Fri, 2 Jun 2023 14:45:55 +0000 (16:45 +0200)]
Bump lwext4 for slightly better debugging.

10 months agoBump required private git revision.
Carl Hetherington [Thu, 1 Jun 2023 21:45:39 +0000 (23:45 +0200)]
Bump required private git revision.

10 months agoAdd dcpomatic2_{map,cli} to the main AppImage (#2549).
Carl Hetherington [Wed, 31 May 2023 19:13:34 +0000 (21:13 +0200)]
Add dcpomatic2_{map,cli} to the main AppImage (#2549).

10 months agoDon't show warning when only removing an empty DKDM folder (#2541).
Carl Hetherington [Tue, 30 May 2023 18:31:53 +0000 (20:31 +0200)]
Don't show warning when only removing an empty DKDM folder (#2541).

10 months agoDon't add DKDMs twice (#2545).
Carl Hetherington [Tue, 30 May 2023 16:11:55 +0000 (18:11 +0200)]
Don't add DKDMs twice (#2545).

10 months agoFix errors when mapping DCPs referring to the same asset multiple times (#2542).
Carl Hetherington [Tue, 30 May 2023 15:21:24 +0000 (17:21 +0200)]
Fix errors when mapping DCPs referring to the same asset multiple times (#2542).

10 months agoClarify some test failure messages.
Carl Hetherington [Tue, 30 May 2023 15:20:32 +0000 (17:20 +0200)]
Clarify some test failure messages.

10 months agoAdd a test with hard-linking.
Carl Hetherington [Tue, 30 May 2023 12:42:53 +0000 (14:42 +0200)]
Add a test with hard-linking.

10 months agoMove test into its own method.
Carl Hetherington [Tue, 30 May 2023 12:31:24 +0000 (14:31 +0200)]
Move test into its own method.

10 months agoAdd --config option to map (#2543).
Carl Hetherington [Tue, 30 May 2023 10:23:00 +0000 (12:23 +0200)]
Add --config option to map (#2543).

10 months agoFix disappearing DKDM folders when dragging a folder into its own child (#2540)
Carl Hetherington [Mon, 29 May 2023 23:29:28 +0000 (01:29 +0200)]
Fix disappearing DKDM folders when dragging a folder into its own child (#2540)

10 months agoSupporters update. v2.16.57
Carl Hetherington [Mon, 29 May 2023 20:54:50 +0000 (22:54 +0200)]
Supporters update.

10 months agoFocus the "make DCP/OK" button in the hints dialog (#2539).
Carl Hetherington [Mon, 29 May 2023 20:47:48 +0000 (22:47 +0200)]
Focus the "make DCP/OK" button in the hints dialog (#2539).

11 months agoDon't write Markers to interop CPLs (#2537).
Carl Hetherington [Sun, 28 May 2023 18:59:38 +0000 (20:59 +0200)]
Don't write Markers to interop CPLs (#2537).

11 months agoMissing bump of libdcp version.
Carl Hetherington [Mon, 29 May 2023 07:32:03 +0000 (09:32 +0200)]
Missing bump of libdcp version.

11 months agoReport the number of active channels in DCPs, not the number in the MXF.
Carl Hetherington [Sun, 28 May 2023 21:35:25 +0000 (23:35 +0200)]
Report the number of active channels in DCPs, not the number in the MXF.

11 months agoBump libdcp for fix to crash with interop subtitles (#2536).
Carl Hetherington [Sat, 27 May 2023 21:44:52 +0000 (23:44 +0200)]
Bump libdcp for fix to crash with interop subtitles (#2536).

11 months agoSupporters update.
Carl Hetherington [Sun, 28 May 2023 16:10:17 +0000 (18:10 +0200)]
Supporters update.

11 months agoCleanup: whitespace.
Carl Hetherington [Thu, 18 May 2023 20:23:05 +0000 (22:23 +0200)]
Cleanup: whitespace.

11 months agoCleanup: replace some list with vector.
Carl Hetherington [Thu, 18 May 2023 20:21:33 +0000 (22:21 +0200)]
Cleanup: replace some list with vector.

11 months agoCleanup: using sorting.
Carl Hetherington [Thu, 18 May 2023 20:20:44 +0000 (22:20 +0200)]
Cleanup: using sorting.

11 months agoCleanup: remove unused include.
Carl Hetherington [Thu, 18 May 2023 20:20:34 +0000 (22:20 +0200)]
Cleanup: remove unused include.

11 months agoUpdated cs_CZ translation from Tomáš Begeni.
Carl Hetherington [Mon, 15 May 2023 09:23:07 +0000 (11:23 +0200)]
Updated cs_CZ translation from Tomáš Begeni.

11 months agoPatrons update.
Carl Hetherington [Sun, 14 May 2023 22:13:47 +0000 (00:13 +0200)]
Patrons update.

11 months agoMissing dcpomatic2_map on RPM builds. v2.16.56
Carl Hetherington [Sun, 14 May 2023 10:35:11 +0000 (12:35 +0200)]
Missing dcpomatic2_map on RPM builds.

11 months agoRe-order binary names.
Carl Hetherington [Sat, 13 May 2023 20:39:53 +0000 (22:39 +0200)]
Re-order binary names.

I've no idea why this works (to fix weird errors from the Apple signing
stuff) but it does...

11 months agoCleanup: use a namespace.
Carl Hetherington [Sat, 13 May 2023 20:07:47 +0000 (22:07 +0200)]
Cleanup: use a namespace.

11 months agoCleanup: remove unnecessary explicit.
Carl Hetherington [Sat, 13 May 2023 20:02:53 +0000 (22:02 +0200)]
Cleanup: remove unnecessary explicit.

11 months agoMissing relink of dcpomatic2_map.
Carl Hetherington [Sat, 13 May 2023 19:09:49 +0000 (21:09 +0200)]
Missing relink of dcpomatic2_map.

11 months agoFix missing signing of dcpomatic2_map.
Carl Hetherington [Sat, 13 May 2023 17:14:20 +0000 (19:14 +0200)]
Fix missing signing of dcpomatic2_map.

11 months agoSupporters update.
Carl Hetherington [Sat, 13 May 2023 15:36:16 +0000 (17:36 +0200)]
Supporters update.

11 months agoAdd dcpomatic2_map tool (#2445).
Carl Hetherington [Fri, 17 Feb 2023 23:15:30 +0000 (00:15 +0100)]
Add dcpomatic2_map tool (#2445).

11 months agoCleanup: using ordering.
Carl Hetherington [Fri, 14 Apr 2023 14:41:38 +0000 (16:41 +0200)]
Cleanup: using ordering.

11 months agoFix typos in errors.
Carl Hetherington [Tue, 11 Apr 2023 21:04:24 +0000 (23:04 +0200)]
Fix typos in errors.

11 months agoFix typo in variable name.
Carl Hetherington [Tue, 11 Apr 2023 21:04:07 +0000 (23:04 +0200)]
Fix typo in variable name.

11 months agoRemove unused define.
Carl Hetherington [Tue, 11 Apr 2023 21:03:40 +0000 (23:03 +0200)]
Remove unused define.

11 months agoFix some typos in comments.
Carl Hetherington [Tue, 11 Apr 2023 21:03:36 +0000 (23:03 +0200)]
Fix some typos in comments.

11 months agoAdd verify_dcp().
Carl Hetherington [Fri, 17 Feb 2023 23:15:10 +0000 (00:15 +0100)]
Add verify_dcp().

11 months agoOnly add fonts to assets when they are required.
Carl Hetherington [Fri, 12 May 2023 00:19:36 +0000 (02:19 +0200)]
Only add fonts to assets when they are required.

11 months agoCleanup: whitespace fix.
Carl Hetherington [Thu, 11 May 2023 22:46:28 +0000 (00:46 +0200)]
Cleanup: whitespace fix.

11 months agoHandle fonts for ccaps coming from DCP content (#2525).
Carl Hetherington [Thu, 11 May 2023 11:50:57 +0000 (13:50 +0200)]
Handle fonts for ccaps coming from DCP content (#2525).

Not dealing with them calls all sort of chaos as described in the
bug report.

11 months agoadd_fonts_from_examiner() can be called multiple times with the same font
Carl Hetherington [Thu, 11 May 2023 11:48:58 +0000 (13:48 +0200)]
add_fonts_from_examiner() can be called multiple times with the same font
in the case of closed captions with multiple tracks.  Don't reuse the
same font objects in this case, otherwise we will start with something
like font, disambiguate it to 0_font, then disambiguate _that_ to
0_0_font.

11 months agoFix _text_count for ccaps when there are multiple reels.
Carl Hetherington [Thu, 11 May 2023 11:47:35 +0000 (13:47 +0200)]
Fix _text_count for ccaps when there are multiple reels.

Previously we would get a _text_count of 1 for open subs, no matter
how many reels there were, but for ccaps the _text_count would
increase with the number of tracks _and_ the number of reels.

11 months agoFix comment.
Carl Hetherington [Thu, 11 May 2023 11:45:02 +0000 (13:45 +0200)]
Fix comment.

11 months agoAllow copy-construction of Font.
Carl Hetherington [Thu, 11 May 2023 11:44:57 +0000 (13:44 +0200)]
Allow copy-construction of Font.