dcpomatic.git
6 weeks agoFix incorrect file adding during merge.
Carl Hetherington [Wed, 8 May 2024 06:07:24 +0000 (08:07 +0200)]
Fix incorrect file adding during merge.

6 weeks agoMerge remote-tracking branch 'origin/main' into v2.17.x
Carl Hetherington [Tue, 7 May 2024 23:53:50 +0000 (01:53 +0200)]
Merge remote-tracking branch 'origin/main' into v2.17.x

6 weeks agoMerge branch 'main' into v2.17.x
Carl Hetherington [Tue, 7 May 2024 23:50:09 +0000 (01:50 +0200)]
Merge branch 'main' into v2.17.x

6 weeks agoWork around deadlock when destroying J2KEncoder with a full writer queue (#2784). v2.16.83
Carl Hetherington [Sun, 5 May 2024 19:34:29 +0000 (21:34 +0200)]
Work around deadlock when destroying J2KEncoder with a full writer queue (#2784).

This feels like a hack, but I can't think of a nicer way to do it.

The interruption disable makes sense because when we destroy encoder threads
during a DCP encode (because a remote server goes away, for example) we don't
want any frames to be lost due to the encode thread being interrupted between
taking the frame off the queue and sending it to the writer.

When we're destroying the encoder we don't care about this, but I can't see
how you'd differentiate.

Maybe the encoder queue could have two lists: to-do and in-progress;
the encoder thread atomically moves a frame from to-do to in-progress,
but then how do you know when the in-progress ones are orphaned and need
to be re-added to the main queue.

You could make the writer return saying "no" if the queue is full (rather
than blocking and waiting for the queue to empty) but that seems wasteful
as then the frame would be re-encoded.

6 weeks agoAdd some missing includes.
Carl Hetherington [Sun, 5 May 2024 19:34:22 +0000 (21:34 +0200)]
Add some missing includes.

6 weeks agoSupporters update.
Carl Hetherington [Tue, 7 May 2024 22:33:13 +0000 (00:33 +0200)]
Supporters update.

6 weeks agoUse sqlite for cinema and DKDM recipient lists.
Carl Hetherington [Sat, 20 May 2023 20:51:49 +0000 (22:51 +0200)]
Use sqlite for cinema and DKDM recipient lists.

6 weeks agoMake version acceptable to dpkg-buildpackage even if the git commit hash starts with...
Carl Hetherington [Sun, 5 May 2024 10:57:46 +0000 (12:57 +0200)]
Make version acceptable to dpkg-buildpackage even if the git commit hash starts with a letter.

6 weeks agoWe now need to import print() for older Pythons.
Carl Hetherington [Sun, 5 May 2024 10:27:28 +0000 (12:27 +0200)]
We now need to import print() for older Pythons.

6 weeks agoRemove use of f-strings in wscripts
Carl Hetherington [Sun, 5 May 2024 09:58:18 +0000 (11:58 +0200)]
Remove use of f-strings in wscripts

Various Linux build environments have a python that is too old.

6 weeks agoCleanup a test and make it a bit more robust.
Carl Hetherington [Fri, 3 May 2024 12:37:24 +0000 (14:37 +0200)]
Cleanup a test and make it a bit more robust.

6 weeks agoUse check_via_pkg_config for libdcp to clarify the error when
Carl Hetherington [Sat, 20 May 2023 20:51:17 +0000 (22:51 +0200)]
Use check_via_pkg_config for libdcp to clarify the error when
you have an old libdcp installed.

6 weeks agoAdd check_via_pkg_config to wscript
Carl Hetherington [Sat, 20 May 2023 20:50:54 +0000 (22:50 +0200)]
Add check_via_pkg_config to wscript

7 weeks agoRemove in-place translations support.
Carl Hetherington [Fri, 3 May 2024 22:19:00 +0000 (00:19 +0200)]
Remove in-place translations support.

It feels like there have been too many failed attempts and not
enough (maybe zero?) successes so it's just too confusing.

7 weeks agoUpdated cs_CZ translation from Tomáš Begeni.
Carl Hetherington [Thu, 2 May 2024 13:48:13 +0000 (15:48 +0200)]
Updated cs_CZ translation from Tomáš Begeni.

7 weeks agoRemove stray '
Carl Hetherington [Mon, 29 Apr 2024 18:44:14 +0000 (20:44 +0200)]
Remove stray '

7 weeks agoMerge branch 'main' into v2.17.x
Carl Hetherington [Wed, 1 May 2024 08:15:18 +0000 (10:15 +0200)]
Merge branch 'main' into v2.17.x

7 weeks agoUse plain git hash for VERSION when there is no exact tag.
Carl Hetherington [Sat, 27 Apr 2024 15:41:52 +0000 (17:41 +0200)]
Use plain git hash for VERSION when there is no exact tag.

7 weeks agoDon't "pollute" the library path with /usr/local/lib.
Carl Hetherington [Mon, 29 Apr 2024 20:41:37 +0000 (22:41 +0200)]
Don't "pollute" the library path with /usr/local/lib.

Sometimes we don't want to use the stuff in there.

7 weeks agoSupporters update. v2.16.82
Carl Hetherington [Tue, 30 Apr 2024 09:20:53 +0000 (11:20 +0200)]
Supporters update.

7 weeks agoFix silent stereo mixdown exports when the project audio channel count is > 6.
Carl Hetherington [Mon, 29 Apr 2024 20:34:51 +0000 (22:34 +0200)]
Fix silent stereo mixdown exports when the project audio channel count is > 6.

This became much more of a problem when we started defaulting to 8 channels
in projects.

7 weeks agoFix failures in real_encode_with_server.
Carl Hetherington [Mon, 29 Apr 2024 08:49:22 +0000 (10:49 +0200)]
Fix failures in real_encode_with_server.

This test suddenly started failing because the server is never found,
so never encodes any frames.

It's a mystery why this started failing, and even more of a mystery
why there seem to be two distinct reasons.

Some failures were apparently due to firewalld blocking UDP broadcast;
disabling the firewall would make the test pass again.

Other failures were apparently caused by an old EncodeServerFinder
hanging around, presumably finding servers before a new one had the
chance.

7 weeks agoCleanup a few verbose asio-related calls.
Carl Hetherington [Sun, 28 Apr 2024 22:11:51 +0000 (00:11 +0200)]
Cleanup a few verbose asio-related calls.

7 weeks agoAdd missing nice name for Windows executable.
Carl Hetherington [Sun, 28 Apr 2024 20:46:13 +0000 (22:46 +0200)]
Add missing nice name for Windows executable.

7 weeks agoWrite file descriptions to .exe files for the Windows task manager.
Carl Hetherington [Sun, 28 Apr 2024 18:34:52 +0000 (20:34 +0200)]
Write file descriptions to .exe files for the Windows task manager.

7 weeks agoBuild .rc files on the fly.
Carl Hetherington [Sat, 27 Apr 2024 15:29:38 +0000 (17:29 +0200)]
Build .rc files on the fly.

7 weeks agoUse plain git hash for VERSION when there is no exact tag.
Carl Hetherington [Sat, 27 Apr 2024 15:41:52 +0000 (17:41 +0200)]
Use plain git hash for VERSION when there is no exact tag.

8 weeks agoAllow branding of "report a problem" dialog.
Carl Hetherington [Fri, 26 Apr 2024 20:34:35 +0000 (22:34 +0200)]
Allow branding of "report a problem" dialog.

8 weeks agoSplash behaviour does not need to be branded after all.
Carl Hetherington [Fri, 26 Apr 2024 10:09:47 +0000 (12:09 +0200)]
Splash behaviour does not need to be branded after all.

8 weeks agoAllow customisation of error report email address.
Carl Hetherington [Fri, 26 Apr 2024 09:53:40 +0000 (11:53 +0200)]
Allow customisation of error report email address.

8 weeks agoApply fixup to test/data submodule and bring it back to the v2.18.x branch.
Carl Hetherington [Wed, 24 Apr 2024 17:38:24 +0000 (19:38 +0200)]
Apply fixup to test/data submodule and bring it back to the v2.18.x branch.

8 weeks agoRestore time zone to Cinema and improve UI to use it (#2473).
Carl Hetherington [Tue, 23 Apr 2024 23:49:09 +0000 (01:49 +0200)]
Restore time zone to Cinema and improve UI to use it (#2473).

8 weeks agoSupporters update. v2.16.81
Carl Hetherington [Wed, 24 Apr 2024 00:11:29 +0000 (02:11 +0200)]
Supporters update.

8 weeks agoRevert "Tweak how lzma is linked."
Carl Hetherington [Mon, 22 Apr 2024 22:38:14 +0000 (00:38 +0200)]
Revert "Tweak how lzma is linked."

This reverts commit 604a5f9343eebfa0108a19bb6b8ec60bc81f4819.

I don't know why I did this, and it breaks the mac-old (10.8) target
as the lzma.5.dylib is not present on those machines.

8 weeks agoBump libdcp for Centos 7 build fix.
Carl Hetherington [Mon, 22 Apr 2024 20:46:44 +0000 (22:46 +0200)]
Bump libdcp for Centos 7 build fix.

2 months agoMerge branch 'mpeg2' into v2.17.x v2.17.16
Carl Hetherington [Mon, 22 Apr 2024 19:39:03 +0000 (21:39 +0200)]
Merge branch 'mpeg2' into v2.17.x

2 months agoClarify a test result when it fails. mpeg2
Carl Hetherington [Wed, 10 Apr 2024 08:13:31 +0000 (10:13 +0200)]
Clarify a test result when it fails.

2 months agoDon't emit video until film's end if we are seeking.
Carl Hetherington [Mon, 8 Apr 2024 21:59:39 +0000 (23:59 +0200)]
Don't emit video until film's end if we are seeking.

Otherwise if we seek to the frame just before the end of the DCP
we'll call emit_video_until() with _next_video unset, causing that
method to emit video for the whole film.

The point of this emit_video_until() call is only to pad a space
between the end of the video content and the end of the film.

2 months agoFix dcpomatic_player script for macOS.
Carl Hetherington [Mon, 8 Apr 2024 21:57:34 +0000 (23:57 +0200)]
Fix dcpomatic_player script for macOS.

2 months agoReport video range from MPEG2 DCPs correctly.
Carl Hetherington [Sun, 7 Apr 2024 21:44:26 +0000 (23:44 +0200)]
Report video range from MPEG2 DCPs correctly.

2 months agoUse mpeg2 prefix for MPEG2 video asset filenames.
Carl Hetherington [Sun, 7 Apr 2024 21:44:12 +0000 (23:44 +0200)]
Use mpeg2 prefix for MPEG2 video asset filenames.

2 months agoDisable some hints when encoding to MPEG2.
Carl Hetherington [Sun, 7 Apr 2024 18:12:20 +0000 (20:12 +0200)]
Disable some hints when encoding to MPEG2.

2 months agoRemove unused Windows identifier stuff (removed from cdist).
Carl Hetherington [Sat, 6 Apr 2024 19:16:41 +0000 (21:16 +0200)]
Remove unused Windows identifier stuff (removed from cdist).

2 months agoAllow specification of video bit rate separately for J2K and MPEG2.
Carl Hetherington [Fri, 5 Apr 2024 21:17:03 +0000 (23:17 +0200)]
Allow specification of video bit rate separately for J2K and MPEG2.

2 months agoAlert user when fixing settings for MPEG2.
Carl Hetherington [Wed, 3 Apr 2024 21:27:41 +0000 (23:27 +0200)]
Alert user when fixing settings for MPEG2.

2 months agoDesensitise things that can't be adjusted in MPEG2 mode.
Carl Hetherington [Wed, 3 Apr 2024 21:27:13 +0000 (23:27 +0200)]
Desensitise things that can't be adjusted in MPEG2 mode.

2 months agoUpdate available containers whenever they change, always adding the one that the...
Carl Hetherington [Wed, 3 Apr 2024 21:26:50 +0000 (23:26 +0200)]
Update available containers whenever they change, always adding the one that the film is currently using.

2 months agoAdd Choice::set_entries().
Carl Hetherington [Wed, 3 Apr 2024 21:25:19 +0000 (23:25 +0200)]
Add Choice::set_entries().

2 months agoRename Choice::add to Choice::add_entry.
Carl Hetherington [Wed, 3 Apr 2024 21:02:41 +0000 (23:02 +0200)]
Rename Choice::add to Choice::add_entry.

2 months agoUnify indentation at 4 spaces.
Carl Hetherington [Mon, 1 Apr 2024 21:42:08 +0000 (23:42 +0200)]
Unify indentation at 4 spaces.

2 months agoUse run/environment for paths in run/tests.
Carl Hetherington [Mon, 1 Apr 2024 21:41:33 +0000 (23:41 +0200)]
Use run/environment for paths in run/tests.

2 months agoSupport encoding of MPEG2 DCPs.
Carl Hetherington [Tue, 19 Mar 2024 13:02:47 +0000 (14:02 +0100)]
Support encoding of MPEG2 DCPs.

2 months agoSupport playback of MPEG2 DCPs.
Carl Hetherington [Wed, 29 Nov 2023 23:46:00 +0000 (00:46 +0100)]
Support playback of MPEG2 DCPs.

2 months agoRename j2k_bandwidth -> video_bit_rate.
Carl Hetherington [Fri, 5 Apr 2024 19:57:03 +0000 (21:57 +0200)]
Rename j2k_bandwidth -> video_bit_rate.

2 months agoAdd "build" environment lib to local run script.
Carl Hetherington [Tue, 26 Mar 2024 19:29:49 +0000 (20:29 +0100)]
Add "build" environment lib to local run script.

2 months agoRemove unnecessary library path.
Carl Hetherington [Tue, 26 Mar 2024 19:29:11 +0000 (20:29 +0100)]
Remove unnecessary library path.

2 months agoExtract frame info read/write to new class.
Carl Hetherington [Tue, 26 Mar 2024 21:43:10 +0000 (22:43 +0100)]
Extract frame info read/write to new class.

2 months agoExtract VideoEncoder as a parent of J2KEncoder.
Carl Hetherington [Tue, 19 Mar 2024 16:10:27 +0000 (17:10 +0100)]
Extract VideoEncoder as a parent of J2KEncoder.

2 months agoRename Encoder -> FilmEncoder, and subclasses.
Carl Hetherington [Tue, 19 Mar 2024 15:29:13 +0000 (16:29 +0100)]
Rename Encoder -> FilmEncoder, and subclasses.

2 months agoRename classes to follow preparatory renames in libdcp.
Carl Hetherington [Wed, 29 Nov 2023 23:29:16 +0000 (00:29 +0100)]
Rename classes to follow preparatory renames in libdcp.

2 months agoRemove old debian changelog and fix its creation.
Carl Hetherington [Sun, 21 Apr 2024 18:03:39 +0000 (20:03 +0200)]
Remove old debian changelog and fix its creation.

2 months agoBring some more branding into the variant.
Carl Hetherington [Fri, 19 Apr 2024 12:27:41 +0000 (14:27 +0200)]
Bring some more branding into the variant.

2 months agoAdd a little documentation.
Carl Hetherington [Wed, 17 Apr 2024 08:08:06 +0000 (10:08 +0200)]
Add a little documentation.

2 months agoSupport variants in the build scripts.
Carl Hetherington [Wed, 17 Apr 2024 08:01:03 +0000 (10:01 +0200)]
Support variants in the build scripts.

2 months agoCleanup: remove unnecessary obj =
Carl Hetherington [Fri, 19 Apr 2024 10:49:16 +0000 (12:49 +0200)]
Cleanup: remove unnecessary obj =

2 months agoExtract all uses of DCP-o-matic name to allow branding.
Carl Hetherington [Tue, 16 Apr 2024 20:19:39 +0000 (22:19 +0200)]
Extract all uses of DCP-o-matic name to allow branding.

2 months agoTry to make test more robust.
Carl Hetherington [Sat, 20 Apr 2024 22:43:28 +0000 (00:43 +0200)]
Try to make test more robust.

2 months agoMerge remote-tracking branch 'origin/main' into v2.17.x
Carl Hetherington [Fri, 19 Apr 2024 14:35:25 +0000 (16:35 +0200)]
Merge remote-tracking branch 'origin/main' into v2.17.x

2 months agoMissed update to private test repo version. v2.16.80
Carl Hetherington [Thu, 18 Apr 2024 12:00:07 +0000 (14:00 +0200)]
Missed update to private test repo version.

2 months agoMerge remote-tracking branch 'origin/main' into v2.17.x
Carl Hetherington [Thu, 18 Apr 2024 10:08:51 +0000 (12:08 +0200)]
Merge remote-tracking branch 'origin/main' into v2.17.x

2 months agoAdd missing GUI-side verification note descriptions.
Carl Hetherington [Thu, 18 Apr 2024 08:12:25 +0000 (10:12 +0200)]
Add missing GUI-side verification note descriptions.

2 months agoSupporters update.
Carl Hetherington [Wed, 17 Apr 2024 21:30:12 +0000 (23:30 +0200)]
Supporters update.

2 months agoBump libdcp for more relaxed CPL parsing (#2797).
Carl Hetherington [Wed, 17 Apr 2024 21:25:22 +0000 (23:25 +0200)]
Bump libdcp for more relaxed CPL parsing (#2797).

2 months agoSeparate GUI verifier with basic reporting (#1823).
Carl Hetherington [Tue, 9 Apr 2024 00:02:28 +0000 (02:02 +0200)]
Separate GUI verifier with basic reporting (#1823).

2 months agoFix page size of icon SVGs.
Carl Hetherington [Tue, 9 Apr 2024 21:08:05 +0000 (23:08 +0200)]
Fix page size of icon SVGs.

2 months agoSplit VerifyDCPResultPanel so that construction and fill are separate.
Carl Hetherington [Tue, 9 Apr 2024 20:11:56 +0000 (22:11 +0200)]
Split VerifyDCPResultPanel so that construction and fill are separate.

2 months agoSplit VerifyDCPProgressDialog into a panel and a dialog.
Carl Hetherington [Tue, 9 Apr 2024 19:11:32 +0000 (21:11 +0200)]
Split VerifyDCPProgressDialog into a panel and a dialog.

2 months agoSplit VerifyDCPResultDialog into a panel and a dialog.
Carl Hetherington [Tue, 9 Apr 2024 19:11:21 +0000 (21:11 +0200)]
Split VerifyDCPResultDialog into a panel and a dialog.

2 months agoRename VerifyDCPDialog -> VerifyDCPResultDialog.
Carl Hetherington [Tue, 9 Apr 2024 18:56:54 +0000 (20:56 +0200)]
Rename VerifyDCPDialog -> VerifyDCPResultDialog.

2 months agoAdd leaf parameter to DirPickerCtrl.
Carl Hetherington [Tue, 9 Apr 2024 01:15:19 +0000 (03:15 +0200)]
Add leaf parameter to DirPickerCtrl.

2 months agoEllipsize end of DirPickerCtrl labels.
Carl Hetherington [Tue, 9 Apr 2024 01:15:04 +0000 (03:15 +0200)]
Ellipsize end of DirPickerCtrl labels.

2 months agoRename dcpomatic2_verify to dcpomatic2_verify_cli.
Carl Hetherington [Tue, 9 Apr 2024 00:02:21 +0000 (02:02 +0200)]
Rename dcpomatic2_verify to dcpomatic2_verify_cli.

2 months agoDon't use --target-macos-arm64 any more, since it's not supported.
Carl Hetherington [Mon, 15 Apr 2024 21:13:00 +0000 (23:13 +0200)]
Don't use --target-macos-arm64 any more, since it's not supported.

2 months agoFix build on macOS 10.8 (wxWidgets 3.0.5).
Carl Hetherington [Mon, 15 Apr 2024 18:12:39 +0000 (20:12 +0200)]
Fix build on macOS 10.8 (wxWidgets 3.0.5).

2 months agoHopefully fix build with the older wxWidgets use for old macOS.
Carl Hetherington [Wed, 10 Apr 2024 12:29:13 +0000 (14:29 +0200)]
Hopefully fix build with the older wxWidgets use for old macOS.

2 months agoAdd new setup of i18n for macOS (#2778).
Carl Hetherington [Mon, 8 Apr 2024 19:19:23 +0000 (21:19 +0200)]
Add new setup of i18n for macOS (#2778).

2 months agoCleanup: header ordering.
Carl Hetherington [Mon, 8 Apr 2024 16:20:10 +0000 (18:20 +0200)]
Cleanup: header ordering.

2 months agoFix DCP Timeline menu on macOS.
Carl Hetherington [Mon, 8 Apr 2024 16:19:49 +0000 (18:19 +0200)]
Fix DCP Timeline menu on macOS.

2 months agoDisable Reels... button with no film.
Carl Hetherington [Mon, 8 Apr 2024 16:19:39 +0000 (18:19 +0200)]
Disable Reels... button with no film.

2 months agoAdd add-dkdm command to add DKDMs to DCP-o-matic's internal list from the CLI.
Carl Hetherington [Fri, 22 Mar 2024 19:39:38 +0000 (20:39 +0100)]
Add add-dkdm command to add DKDMs to DCP-o-matic's internal list from the CLI.

2 months agoSwitch "command-like" options --list-cinemas and --list-dkdm-cpls to actual commands.
Carl Hetherington [Fri, 22 Mar 2024 19:25:01 +0000 (20:25 +0100)]
Switch "command-like" options --list-cinemas and --list-dkdm-cpls to actual commands.

2 months agoAdd --decryption-key option to KDM CLI (#2790).
Carl Hetherington [Fri, 22 Mar 2024 19:07:37 +0000 (20:07 +0100)]
Add --decryption-key option to KDM CLI (#2790).

2 months agoCleanup: white space.
Carl Hetherington [Fri, 22 Mar 2024 18:59:37 +0000 (19:59 +0100)]
Cleanup: white space.

2 months agoRename --trusted-device to --trusted-device-certificate in the KDM CLI.
Carl Hetherington [Fri, 22 Mar 2024 18:57:33 +0000 (19:57 +0100)]
Rename --trusted-device to --trusted-device-certificate in the KDM CLI.

2 months agoRename --certificate to --projector-certificate in KDM CLI.
Carl Hetherington [Fri, 22 Mar 2024 18:57:04 +0000 (19:57 +0100)]
Rename --certificate to --projector-certificate in KDM CLI.

2 months agoFix hanging/overlapping dvb subtitles (#2792).
Carl Hetherington [Sun, 31 Mar 2024 23:04:41 +0000 (01:04 +0200)]
Fix hanging/overlapping dvb subtitles (#2792).

This reverts a change made in
8ca6fd6d97e6d42492afddb655fa85130946853c
"Fix doubled subtitles if subtitle stop times are specified."

That change breaks the case where a subtitle _does_ have a stop time,
but it's wrong (30s from the start time) and we want the next subtitle
to clear the previous one.

I can't now see how reverting this could cause doubled subtitles,
so maybe that problem wlil come back.  At least now there's a test
for #2792.

2 months agoRemove now-unnecessary --target-macos-arm64 v2.17.15
Carl Hetherington [Sat, 30 Mar 2024 21:20:08 +0000 (22:20 +0100)]
Remove now-unnecessary --target-macos-arm64

2 months agoMerge remote-tracking branch 'origin/main' into v2.17.x
Carl Hetherington [Fri, 29 Mar 2024 23:00:44 +0000 (00:00 +0100)]
Merge remote-tracking branch 'origin/main' into v2.17.x

2 months agoFix crash introduced in previous commit.
Carl Hetherington [Fri, 29 Mar 2024 22:58:36 +0000 (23:58 +0100)]
Fix crash introduced in previous commit.

2 months agoMerge remote-tracking branch 'origin/main' into v2.17.x
Carl Hetherington [Fri, 29 Mar 2024 22:23:10 +0000 (23:23 +0100)]
Merge remote-tracking branch 'origin/main' into v2.17.x