dcpomatic.git
3 months agoInspect all DCPs made during tests with ClairMeta. 76-dcp-inspect
Carl Hetherington [Fri, 12 Jan 2024 14:29:12 +0000 (15:29 +0100)]
Inspect all DCPs made during tests with ClairMeta.

3 months agoInspect all DCPs made during tests with dcp_inspect.
Carl Hetherington [Thu, 11 Jan 2024 15:24:38 +0000 (16:24 +0100)]
Inspect all DCPs made during tests with dcp_inspect.

3 months agoMissing PRIVATE_GIT update from previous.
Carl Hetherington [Mon, 15 Jan 2024 09:25:14 +0000 (10:25 +0100)]
Missing PRIVATE_GIT update from previous.

3 months agoFix handling of empty font IDs and default DCP fonts (#2721) (part of #2722).
Carl Hetherington [Sat, 13 Jan 2024 22:34:35 +0000 (23:34 +0100)]
Fix handling of empty font IDs and default DCP fonts (#2721) (part of #2722).

Previously we used an empty font ID as the default for when a subtitle
has no Font, but in #2721 we saw a DCP with an empty font ID which
raised an assertion (because we'd already added our default font with
the empty ID).

Here we try to fix this (and also make the default font correctly be
that from the first <LoadFont>).

3 months agoIncrease timeout before pulsing the progress bar for a job.
Carl Hetherington [Sun, 14 Jan 2024 23:48:43 +0000 (00:48 +0100)]
Increase timeout before pulsing the progress bar for a job.

3 months agoAdd an assert.
Carl Hetherington [Sat, 13 Jan 2024 20:52:27 +0000 (21:52 +0100)]
Add an assert.

3 months agoShow hashes when they disagree during verification (#2717).
Carl Hetherington [Sat, 13 Jan 2024 00:01:09 +0000 (01:01 +0100)]
Show hashes when they disagree during verification (#2717).

3 months agoUpdated nl_NL translation from Rob van Nieuwkerk.
Carl Hetherington [Fri, 12 Jan 2024 23:13:17 +0000 (00:13 +0100)]
Updated nl_NL translation from Rob van Nieuwkerk.

3 months agoFix scaling of bitmap subs when the corresponding video is cropped (#2670).
Carl Hetherington [Fri, 1 Dec 2023 20:25:54 +0000 (21:25 +0100)]
Fix scaling of bitmap subs when the corresponding video is cropped (#2670).

Previously we would scale the bitmap size/position to a proportion
of the original video frame, then scale it back up again to the DCP
container.  This didn't take into account some cropped cases where
the picture would end up the same shape but the subtitles would be
stretched.

3 months agopot/merge.
Carl Hetherington [Thu, 11 Jan 2024 23:55:10 +0000 (00:55 +0100)]
pot/merge.

3 months agoFix markers view for RTL languages (part of #2696).
Carl Hetherington [Thu, 11 Jan 2024 21:51:23 +0000 (22:51 +0100)]
Fix markers view for RTL languages (part of #2696).

3 months agoFix "add" markers submenu for the last couple of markers.
Carl Hetherington [Thu, 11 Jan 2024 21:51:00 +0000 (22:51 +0100)]
Fix "add" markers submenu for the last couple of markers.

3 months agoAttempt to rationalise menu IDs and avoid duplicates.
Carl Hetherington [Thu, 11 Jan 2024 21:50:29 +0000 (22:50 +0100)]
Attempt to rationalise menu IDs and avoid duplicates.

3 months agoCleanup: using/include sorting.
Carl Hetherington [Thu, 11 Jan 2024 21:49:32 +0000 (22:49 +0100)]
Cleanup: using/include sorting.

3 months agoFix timecode order in RTL languages (part of #2696).
Carl Hetherington [Thu, 11 Jan 2024 20:02:11 +0000 (21:02 +0100)]
Fix timecode order in RTL languages (part of #2696).

3 months agoSupporters update.
Carl Hetherington [Thu, 11 Jan 2024 19:37:57 +0000 (20:37 +0100)]
Supporters update.

3 months agoUpdated fa_IR translation from Soleyman Rahmani.
Carl Hetherington [Thu, 11 Jan 2024 19:24:21 +0000 (20:24 +0100)]
Updated fa_IR translation from Soleyman Rahmani.

3 months agoMore test fixes after changes in c2c6fbdd8dddbb6ccba0a6ae49a13d5364122df7
Carl Hetherington [Thu, 11 Jan 2024 16:08:05 +0000 (17:08 +0100)]
More test fixes after changes in c2c6fbdd8dddbb6ccba0a6ae49a13d5364122df7

3 months agoFix tests after changes in c2c6fbdd8dddbb6ccba0a6ae49a13d5364122df7
Carl Hetherington [Thu, 11 Jan 2024 11:04:48 +0000 (12:04 +0100)]
Fix tests after changes in c2c6fbdd8dddbb6ccba0a6ae49a13d5364122df7

3 months agoReduce minimum "non-standard" ISDCF part name length to 1.
Carl Hetherington [Thu, 11 Jan 2024 10:28:24 +0000 (11:28 +0100)]
Reduce minimum "non-standard" ISDCF part name length to 1.

Otherwise on macOS (at least) you can't type in any numbers, seemingly because
it checks on each keypress so e.g. you clear it, enter 1 and a bell rings because
1 is too small.  It's fine on Linux (a too-small number is corrected when you
press enter).

3 months agoFix crash when changing ISDCF name part length (#2690).
Carl Hetherington [Wed, 10 Jan 2024 22:49:18 +0000 (23:49 +0100)]
Fix crash when changing ISDCF name part length (#2690).

3 months agoMark a VF as having assets, even if they are unresolved (#1024).
Carl Hetherington [Wed, 10 Jan 2024 16:47:32 +0000 (17:47 +0100)]
Mark a VF as having assets, even if they are unresolved (#1024).

This allows them to be displayed in the timeline, hopefully without
any unwanted side-effects.

3 months agoRe-make video after YUV/RGB matrix is changed (#2714).
Carl Hetherington [Tue, 9 Jan 2024 12:02:09 +0000 (13:02 +0100)]
Re-make video after YUV/RGB matrix is changed (#2714).

3 months agoCleanup: white space.
Carl Hetherington [Tue, 9 Jan 2024 12:01:50 +0000 (13:01 +0100)]
Cleanup: white space.

3 months agoCheck for bad DN qualifiers on signer certificates (#2716).
Carl Hetherington [Mon, 8 Jan 2024 18:01:21 +0000 (19:01 +0100)]
Check for bad DN qualifiers on signer certificates (#2716).

3 months agoMove ScopeGuard into libdcp.
Carl Hetherington [Mon, 8 Jan 2024 15:25:42 +0000 (16:25 +0100)]
Move ScopeGuard into libdcp.

3 months agoUpdated fa_IR translation from Soleyman Rahmani.
Carl Hetherington [Sun, 7 Jan 2024 23:51:45 +0000 (00:51 +0100)]
Updated fa_IR translation from Soleyman Rahmani.

3 months agoCleanup: remove unused method.
Carl Hetherington [Fri, 5 Jan 2024 00:38:50 +0000 (01:38 +0100)]
Cleanup: remove unused method.

3 months agoDon't use video streams with AV_DISPOSITION_ATTACHED_PIC (#2349).
Carl Hetherington [Thu, 4 Jan 2024 22:58:56 +0000 (23:58 +0100)]
Don't use video streams with AV_DISPOSITION_ATTACHED_PIC (#2349).

These are seen in MP3 files for cover art.

3 months agoAdd new "territory type" so that INT-T{D,L} can be chosen (#2704).
Carl Hetherington [Fri, 5 Jan 2024 00:28:19 +0000 (01:28 +0100)]
Add new "territory type" so that INT-T{D,L} can be chosen (#2704).

3 months agoAdd Choice::set_by_data().
Carl Hetherington [Fri, 5 Jan 2024 00:26:58 +0000 (01:26 +0100)]
Add Choice::set_by_data().

3 months agoRemove out-of-date patrons.
Carl Hetherington [Fri, 5 Jan 2024 00:52:47 +0000 (01:52 +0100)]
Remove out-of-date patrons.

3 months agoCleanup: longer variable name.
Carl Hetherington [Thu, 4 Jan 2024 22:56:04 +0000 (23:56 +0100)]
Cleanup: longer variable name.

3 months agoMerge branch '2694-remove-odd-check'
Carl Hetherington [Thu, 4 Jan 2024 22:37:15 +0000 (23:37 +0100)]
Merge branch '2694-remove-odd-check'

Allow referring to OVs where not every reel has a subtitle/ccap,
fixing it if required by adding our own reels.

3 months agoAdd a test.
Carl Hetherington [Thu, 28 Dec 2023 23:06:54 +0000 (00:06 +0100)]
Add a test.

3 months agoAdd dummy subtitle and closed caption reels even when referencing
Carl Hetherington [Wed, 3 Jan 2024 23:40:03 +0000 (00:40 +0100)]
Add dummy subtitle and closed caption reels even when referencing
other DCPs (in a VF) that themselves might have missing subtitles
for some reels.

3 months agoFix libdcp to not crash in some VF verification situations.
Carl Hetherington [Fri, 29 Dec 2023 00:31:47 +0000 (01:31 +0100)]
Fix libdcp to not crash in some VF verification situations.

3 months agoDon't try to add fonts from an asset that we don't have.
Carl Hetherington [Fri, 29 Dec 2023 00:30:22 +0000 (01:30 +0100)]
Don't try to add fonts from an asset that we don't have.

3 months agoDon't add an asset that we don't have.
Carl Hetherington [Fri, 29 Dec 2023 00:30:09 +0000 (01:30 +0100)]
Don't add an asset that we don't have.

3 months agoDon't crash when checking a DCP with no subtitles in some reel.
Carl Hetherington [Mon, 25 Dec 2023 00:12:49 +0000 (01:12 +0100)]
Don't crash when checking a DCP with no subtitles in some reel.

3 months agoRemove checks for referenced DCPs having content in all reels (#2694).
Carl Hetherington [Sat, 23 Dec 2023 18:45:05 +0000 (19:45 +0100)]
Remove checks for referenced DCPs having content in all reels (#2694).

I can't see why this was done, other than perhaps to avoid output
with no subtitles in a reel (which is not allowed by Bv2.1).  But
I think even if that does still happen we could make our own reels
for the missing ones.

3 months agoAllow specification of map CPLs by ID (#2702).
Carl Hetherington [Thu, 4 Jan 2024 00:21:10 +0000 (01:21 +0100)]
Allow specification of map CPLs by ID (#2702).

3 months agoUse sudo for apt.
Carl Hetherington [Thu, 21 Dec 2023 22:41:16 +0000 (23:41 +0100)]
Use sudo for apt.

Though the cci instance on main runs things on droplets as root,
on klopp they run as carl.  I made password-less sudo for apt work
on the docker image so this makes the appimage builds work on
klopp too.

3 months agoAdd libthai to AppImage (#2642).
Carl Hetherington [Thu, 21 Dec 2023 21:04:09 +0000 (22:04 +0100)]
Add libthai to AppImage (#2642).

3 months agoRemove tick/no_tick icons which I believe are no longer used.
Carl Hetherington [Tue, 2 Jan 2024 16:28:27 +0000 (17:28 +0100)]
Remove tick/no_tick icons which I believe are no longer used.

They were added to the list in the playlist editor but seemingly
not used.

3 months agoUpdated fa_IR translation from Soleyman Rahmani.
Carl Hetherington [Tue, 2 Jan 2024 15:53:04 +0000 (16:53 +0100)]
Updated fa_IR translation from Soleyman Rahmani.

3 months agoObserve CPL changing, so that (e.g.) Make KDM button becomes sensitive
Carl Hetherington [Tue, 2 Jan 2024 00:58:59 +0000 (01:58 +0100)]
Observe CPL changing, so that (e.g.) Make KDM button becomes sensitive
when selecting a screen and then choosing a CPL by browsing the filesystem
(when there was no CPL previously selected).

3 months agoCleanup: whitespace.
Carl Hetherington [Tue, 2 Jan 2024 00:58:28 +0000 (01:58 +0100)]
Cleanup: whitespace.

3 months agoCleanup: auto.
Carl Hetherington [Tue, 2 Jan 2024 00:58:21 +0000 (01:58 +0100)]
Cleanup: auto.

3 months agoHappy new year.
Carl Hetherington [Mon, 1 Jan 2024 23:45:04 +0000 (00:45 +0100)]
Happy new year.

3 months agoUpdated fa_IR translation from Soleyman Rahmani.
Carl Hetherington [Mon, 1 Jan 2024 23:33:11 +0000 (00:33 +0100)]
Updated fa_IR translation from Soleyman Rahmani.

3 months agoUpdate i18up script for fa_IR.
Carl Hetherington [Mon, 1 Jan 2024 23:32:50 +0000 (00:32 +0100)]
Update i18up script for fa_IR.

3 months agoMissing screenshots for previous.
Carl Hetherington [Mon, 1 Jan 2024 23:19:36 +0000 (00:19 +0100)]
Missing screenshots for previous.

3 months agoSome cursory documentation for the "advanced" player mode.
Carl Hetherington [Mon, 1 Jan 2024 23:17:28 +0000 (00:17 +0100)]
Some cursory documentation for the "advanced" player mode.

3 months agoAdd --screenshot option to playlist editor.
Carl Hetherington [Mon, 1 Jan 2024 23:16:56 +0000 (00:16 +0100)]
Add --screenshot option to playlist editor.

3 months agoUse a variable in the playlist script.
Carl Hetherington [Mon, 1 Jan 2024 23:16:46 +0000 (00:16 +0100)]
Use a variable in the playlist script.

3 months agoFix crash due to player_video().first becoming null sometime between
Carl Hetherington [Mon, 1 Jan 2024 23:15:47 +0000 (00:15 +0100)]
Fix crash due to player_video().first becoming null sometime between
it being passed into the method and then being re-read via
another call to player_video().

3 months agoAdd --screenshot option to player.
Carl Hetherington [Sun, 31 Dec 2023 15:51:57 +0000 (16:51 +0100)]
Add --screenshot option to player.

3 months agoUse $binary to save some typing.
Carl Hetherington [Sun, 31 Dec 2023 15:51:28 +0000 (16:51 +0100)]
Use $binary to save some typing.

3 months agoAdd a little gap between player buttons and the position slider.
Carl Hetherington [Sun, 31 Dec 2023 15:51:12 +0000 (16:51 +0100)]
Add a little gap between player buttons and the position slider.

3 months agoCleanup: use some auto.
Carl Hetherington [Sun, 31 Dec 2023 15:51:00 +0000 (16:51 +0100)]
Cleanup: use some auto.

3 months agoFix macOS build for previous.
Carl Hetherington [Sun, 31 Dec 2023 00:28:35 +0000 (01:28 +0100)]
Fix macOS build for previous.

3 months agoBetter logging to help with #2701.
Carl Hetherington [Sat, 30 Dec 2023 23:58:40 +0000 (00:58 +0100)]
Better logging to help with #2701.

3 months agoTry to clarify player "dual" mode in the configuration.
Carl Hetherington [Sat, 30 Dec 2023 23:08:47 +0000 (00:08 +0100)]
Try to clarify player "dual" mode in the configuration.

4 months agoAdd stubs for fa_IR (Farsi/Persian). v2.16.71
Carl Hetherington [Sun, 24 Dec 2023 16:10:07 +0000 (17:10 +0100)]
Add stubs for fa_IR (Farsi/Persian).

4 months agoFix crash with a non-existent playlist directory.
Carl Hetherington [Sat, 23 Dec 2023 09:57:49 +0000 (10:57 +0100)]
Fix crash with a non-existent playlist directory.

4 months agoBump libsub to fix #2685.
Carl Hetherington [Fri, 22 Dec 2023 18:38:18 +0000 (19:38 +0100)]
Bump libsub to fix #2685.

4 months agoBump openssl to one derived from 3.2.0 (#2679).
Carl Hetherington [Sun, 17 Dec 2023 23:56:09 +0000 (00:56 +0100)]
Bump openssl to one derived from 3.2.0 (#2679).

4 months agoImprove positioning of player windows in dual screen mode.
Carl Hetherington [Tue, 19 Dec 2023 20:24:00 +0000 (21:24 +0100)]
Improve positioning of player windows in dual screen mode.

4 months agoAdd some logging to show what's going on with the wxDisplays.
Carl Hetherington [Tue, 19 Dec 2023 19:31:08 +0000 (20:31 +0100)]
Add some logging to show what's going on with the wxDisplays.

4 months agoFix bits missed from previous commit.
Carl Hetherington [Tue, 19 Dec 2023 13:50:42 +0000 (14:50 +0100)]
Fix bits missed from previous commit.

4 months agoFix sensitivity of KDM create button when no output method has been chosen.
Carl Hetherington [Tue, 19 Dec 2023 13:44:20 +0000 (14:44 +0100)]
Fix sensitivity of KDM create button when no output method has been chosen.

4 months agoRun premultiply filter on still images that have alpha channels (more of #2681).
Carl Hetherington [Sun, 10 Dec 2023 20:53:38 +0000 (21:53 +0100)]
Run premultiply filter on still images that have alpha channels (more of #2681).

4 months agoCleanup: const.
Carl Hetherington [Sun, 10 Dec 2023 20:52:45 +0000 (21:52 +0100)]
Cleanup: const.

4 months agoPrevent crash if you forget to call FilterGraph::setup().
Carl Hetherington [Sun, 10 Dec 2023 20:52:41 +0000 (21:52 +0100)]
Prevent crash if you forget to call FilterGraph::setup().

4 months agoAdd a premultiply filter to sources with an alpha channel (#2681).
Carl Hetherington [Sun, 10 Dec 2023 15:20:51 +0000 (16:20 +0100)]
Add a premultiply filter to sources with an alpha channel (#2681).

4 months agoAdd FFmpegExaminer::has_alpha().
Carl Hetherington [Sun, 10 Dec 2023 15:20:20 +0000 (16:20 +0100)]
Add FFmpegExaminer::has_alpha().

4 months agoCleanup: use a lambda.
Carl Hetherington [Sun, 10 Dec 2023 15:20:02 +0000 (16:20 +0100)]
Cleanup: use a lambda.

4 months agoCleanup: use some better variable names.
Carl Hetherington [Sat, 9 Dec 2023 19:33:02 +0000 (20:33 +0100)]
Cleanup: use some better variable names.

4 months agoDon't scan content if we don't need to (#2661).
Carl Hetherington [Fri, 8 Dec 2023 15:45:55 +0000 (16:45 +0100)]
Don't scan content if we don't need to (#2661).

4 months agoExtract scan_content().
Carl Hetherington [Fri, 8 Dec 2023 15:00:49 +0000 (16:00 +0100)]
Extract scan_content().

4 months agoSupport YUV422P9LE in alpha_blend() (#2671). notar1
Carl Hetherington [Mon, 27 Nov 2023 23:33:22 +0000 (00:33 +0100)]
Support YUV422P9LE in alpha_blend() (#2671).

4 months agoSupporters update. v2.16.70
Carl Hetherington [Fri, 1 Dec 2023 23:40:10 +0000 (00:40 +0100)]
Supporters update.

4 months agoBump libdcp for another MCA channel ID fix.
Carl Hetherington [Fri, 1 Dec 2023 23:39:14 +0000 (00:39 +0100)]
Bump libdcp for another MCA channel ID fix.

4 months agoSupport RtAudio >= 6.
Carl Hetherington [Thu, 30 Nov 2023 21:15:46 +0000 (22:15 +0100)]
Support RtAudio >= 6.

There's an API break, mostly about removing the use of exceptions.

4 months agoAllow 14 or 16 channels with ATMOS content, rather than forcing 14 (#2672).
Carl Hetherington [Wed, 29 Nov 2023 01:27:50 +0000 (02:27 +0100)]
Allow 14 or 16 channels with ATMOS content, rather than forcing 14 (#2672).

4 months agoDon't reduce the audio channel count on adding ATMOS (only increase it, if required).
Carl Hetherington [Wed, 29 Nov 2023 01:26:07 +0000 (02:26 +0100)]
Don't reduce the audio channel count on adding ATMOS (only increase it, if required).

4 months agoFix segfault when creating KDMs with certificates and project folders (not DKDMs).
Carl Hetherington [Wed, 29 Nov 2023 21:50:34 +0000 (22:50 +0100)]
Fix segfault when creating KDMs with certificates and project folders (not DKDMs).

5 months agoAdd Дима Агатов as a tester.
Carl Hetherington [Mon, 27 Nov 2023 09:34:04 +0000 (10:34 +0100)]
Add Дима Агатов as a tester.

5 months agoSupporters update. v2.16.69
Carl Hetherington [Sun, 26 Nov 2023 23:56:28 +0000 (00:56 +0100)]
Supporters update.

5 months agoUninstall encode server link.
Carl Hetherington [Sat, 25 Nov 2023 23:40:12 +0000 (00:40 +0100)]
Uninstall encode server link.

5 months agoAdd missing file=f so that all desktop shortcuts are uninstalled.
Carl Hetherington [Sat, 25 Nov 2023 23:06:46 +0000 (00:06 +0100)]
Add missing file=f so that all desktop shortcuts are uninstalled.

5 months agoSet shell var context so that when uninstalling we look in the same place for shortcu...
Carl Hetherington [Sat, 25 Nov 2023 21:14:56 +0000 (22:14 +0100)]
Set shell var context so that when uninstalling we look in the same place for shortcuts as when installing.

5 months agoCleanup: add start_menu_shortcut().
Carl Hetherington [Sat, 25 Nov 2023 21:13:39 +0000 (22:13 +0100)]
Cleanup: add start_menu_shortcut().

5 months agoExtract some common parts of the uninstaller.
Carl Hetherington [Sat, 25 Nov 2023 21:05:24 +0000 (22:05 +0100)]
Extract some common parts of the uninstaller.

5 months agoCleanup: remove unnecessary include.
Carl Hetherington [Sat, 25 Nov 2023 20:08:39 +0000 (21:08 +0100)]
Cleanup: remove unnecessary include.

5 months agoCall dcpomatic_setup_path_encoding() early enough (#2665).
Carl Hetherington [Sat, 25 Nov 2023 20:07:50 +0000 (21:07 +0100)]
Call dcpomatic_setup_path_encoding() early enough (#2665).

On Windows this was previously called after we instantiated a Config
object to get win32_console(), meaning that the required path voodoo
was not active when looking for the config.  This caused problems
if the user has a non-ASCII user name.

5 months agoDon't hide errors when trying to make configuration directories.
Carl Hetherington [Sat, 25 Nov 2023 20:06:18 +0000 (21:06 +0100)]
Don't hide errors when trying to make configuration directories.

There should be no error if the directories already exist, and otherwise
I think we want to know about the error.

5 months agoFix installer with non-ASCII user names (#2668).
Carl Hetherington [Sat, 25 Nov 2023 12:34:02 +0000 (13:34 +0100)]
Fix installer with non-ASCII user names (#2668).

5 months agoFix stray \r characters in output of ls_url on Windows (#2669).
Carl Hetherington [Sun, 26 Nov 2023 21:05:48 +0000 (22:05 +0100)]
Fix stray \r characters in output of ls_url on Windows (#2669).